fix: close popups before showing launchpad

[18202781743]

Summary by Sourcery

Bug Fixes:

• Prevent the launcher from becoming visible while other Qt popups are still active by deferring its display until popups are closed.

[sourcery-ai]

Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Implements deferred launcher visibility changes to ensure all Qt popups are closed and their Wayland grabs released before showing the launchpad, using a pending-show flag and a zero-timeout timer callback.

Sequence diagram for deferred launcher visibility when popups are open

sequenceDiagram
    participant Caller
    participant LauncherController
    participant QGuiApplicationPrivate
    participant QTimer

    Caller->>LauncherController: setVisible(true)
    LauncherController->>QGuiApplicationPrivate: popupCount()
    QGuiApplicationPrivate-->>LauncherController: popupCount > 0
    LauncherController->>LauncherController: m_showPending = true
    LauncherController->>LauncherController: closeAllPopups()
    LauncherController->>QTimer: singleShot(0, this, lambda)

    QTimer-->>LauncherController: lambda callback
    alt m_showPending is true
        LauncherController->>LauncherController: m_showPending = false
        LauncherController->>LauncherController: setVisible(true)
    else m_showPending is false
        LauncherController->>LauncherController: [return]
    end

Loading

File-Level Changes

Change	Details	Files
Guard launcher visibility changes with a pending-show flag and defer showing until after popups are closed.	Return early when hiding while a pending show is scheduled, cancelling the pending show instead Avoid redundant visibility changes by returning when the requested visibility matches the current state or when a show is already pending When a show is requested while any Qt popups are open, mark the show as pending, close all popups, and schedule a deferred visibility change using QTimer::singleShot In the deferred callback, re-check the pending flag, clear it, and call setVisible(true) to actually show the launcher	launchercontroller.cpp
Extend launcher controller state to track pending show requests and update copyright metadata.	Add a new m_showPending boolean member, initialized to false, to track deferred show operations Update the SPDX-FileCopyrightText year range to 2023 - 2026	launchercontroller.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[18202781743]

在x11和wayland下，任务栏上的右键菜单弹出后，再用快捷键启动小启动器，菜单不消失，
在treeland下，小启动器位置还会错误，

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

★ 总体评分：100分

■ 【总体评价】

代码精准修复了Wayland下popup grab冲突导致的卡死问题，逻辑严谨且无副作用
逻辑完全正确、质量良好、性能无损耗且无安全漏洞，给予满分

■ 【详细分析】

• 1.语法逻辑（正确）✓
  在 LauncherController::setVisible 函数中，通过引入 m_showPending 状态变量完美处理了异步延时调用期间的竞态条件。首段 if 拦截了在等待期间触发的隐藏请求并清理状态；第二段 if 防止了重复的显示请求；QTimer::singleShot 内部再次检查 m_showPending 确保了状态一致性。
  建议：当前逻辑已十分完善，无需额外修改。

• 2.代码质量（良好）✓
  新增的 m_showPending 变量命名清晰，准确表达了等待显示的语义。代码中保留了详尽的英文注释，明确解释了为何要在 Wayland 环境下等待 Qt 释放 popup grab，极大提升了代码的可维护性。头文件中的变量初始化 bool m_showPending = false; 遵循了现代 C++ 的类内初始化规范。
  建议：继续保持这种高质量的注释和命名习惯。

• 3.代码性能（无性能问题）✓
  使用 QTimer::singleShot(0, this, ...) 将实际显示操作推迟到当前事件循环处理完毕后执行，仅增加了一次事件循环派发的开销，时间复杂度为 O(1)，没有引入任何轮询、阻塞或额外的系统调用，对启动器响应性能的影响微乎其微。
  建议：无需优化。

• 4.代码安全（存在0个安全漏洞）✓
  漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个
  代码未涉及外部输入处理、命令执行、文件操作或网络通信。Lambda 表达式通过 QTimer::singleShot 的上下文对象参数绑定了 this，确保了若 LauncherController 实例在异步回调触发前被销毁，定时器会被 Qt 框架自动取消，彻底杜绝了悬空指针引发的内存越界或崩溃风险。
  建议：保持当前安全的异步调用模式。

■ 【改进建议代码示例】

// 当前代码已足够优秀，以下展示一种可选的微调方式，将魔法值 0 提取为常量以增加可读性（非强制）
// launchercontroller.h
class LauncherController : public QObject
{
    // ...
    bool m_showPending = false;
    // ...
};

// launchercontroller.cpp
void LauncherController::setVisible(bool visible)
{
    if (!visible && m_showPending) {
        m_showPending = false;
        return;
    }

    if (visible == m_visible || (visible && m_showPending)) return;

    if (visible && QGuiApplicationPrivate::popupCount() > 0) {
        m_showPending = true;
        closeAllPopups();

        // Let Qt finish hiding the current popup and release the Wayland
        // popup grab before the launcher window is mapped.
        QTimer::singleShot(0, this, [this] {
            if (!m_showPending) {
                return;
            }

            m_showPending = false;
            setVisible(true);
        });
        return;
    }

    m_visible = visible;
    // ... (后续原有逻辑)
}

[18202781743]

/forcemerge

[deepin-bot]

This pr force merged! (status: blocked)