feat(power): hand service to dde-services - #1202
Open
mhduiy wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideTransfers Power1 service ownership from dde-daemon to dde-services by disabling legacy power modules and removing their packaging assets, while updating dependency and metadata in debian/control. Sequence diagram for Power1 DBus calls now handled by dde-servicessequenceDiagram
actor Client
participant DBus
participant dde_services
Client->>DBus: Call org.deepin.dde.Power1.method
DBus->>dde_services: Route Power1 method
dde_services-->>DBus: Return result
DBus-->>Client: Deliver result
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot TAG: 6.1.102 |
1. Disable legacy session and system Power module registration. 2. Remove migrated Power assets from dde-daemon packaging. 3. Make dde-services the sole Power1 owner. Log: Transfer Power service ownership from dde-daemon to dde-services. Influence: Upgrades avoid duplicate Power1 ownership. feat(power): 将服务移交 dde-services 1. 禁用 dde-daemon 中旧的会话与系统电源模块注册。 2. 从 dde-daemon 打包中移除已迁移的电源资源。 3. 由 dde-services 单独提供 Power1 服务。 Log: 将电源服务所有权从 dde-daemon 移交至 dde-services。 PMS: TASK-394241 Influence: 升级时避免重复提供 Power1 服务。
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/Makefile b/Makefile
index 7a7d48bf2..123456789 100644
--- a/Makefile
+++ b/Makefile
@@ -171,13 +171,10 @@ install: build install-dde-data install-icons
mkdir -pv ${DESTDIR}${PREFIX}/share/dbus-1/system.d
cp misc/conf/*.conf ${DESTDIR}${PREFIX}/share/dbus-1/system.d/
- rm -f ${DESTDIR}${PREFIX}/share/dbus-1/system.d/org.deepin.dde.Power1.conf
mkdir -pv ${DESTDIR}${PREFIX}/share/dbus-1
cp -r misc/services ${DESTDIR}${PREFIX}/share/dbus-1/
cp -r misc/system-services ${DESTDIR}${PREFIX}/share/dbus-1/
- rm -f ${DESTDIR}${PREFIX}/share/dbus-1/system-services/org.deepin.dde.Power1.service
mkdir -pv ${DESTDIR}${PREFIX}/share/polkit-1/actions
cp misc/polkit-action/*.policy ${DESTDIR}${PREFIX}/share/polkit-1/actions/
- rm -f ${DESTDIR}${PREFIX}/share/polkit-1/actions/org.deepin.dde.power.policy
mkdir -pv ${DESTDIR}${PREFIX}/share/polkit-1/rules.d/
cp misc/polkit-rules/*.rules ${DESTDIR}${PREFIX}/share/polkit-1/rules.d/
@@ -215,6 +212,5 @@ install: build install-dde-data install-icons
mkdir -pv ${DESTDIR}${PREFIX}/share/dsg/configs/org.deepin.dde.daemon/
cp -r misc/dsg-configs/*.json ${DESTDIR}${PREFIX}/share/dsg/configs/org.deepin.dde.daemon/
- rm -f ${DESTDIR}${PREFIX}/share/dsg/configs/org.deepin.dde.daemon/org.deepin.dde.daemon.power.json
mkdir -pv ${DESTDIR}${PREFIX}/share/dsg/configs/org.deepin.dde.lightdm-deepin-greeter |
Contributor
|
TAG Bot New tag: 6.1.102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Transfer Power service ownership from dde-daemon to dde-services.
Influence: Upgrades avoid duplicate Power1 ownership.
feat(power): 将服务移交 dde-services
Log: 将电源服务所有权从 dde-daemon 移交至 dde-services。
PMS: TASK-394241
Influence: 升级时避免重复提供 Power1 服务。
Validation: