cli: handle broken stdout pipes gracefully - #14
Open
dishendradeshmukh1986 wants to merge 1 commit into
Open
Conversation
Rust's print macros panic when stdout returns EPIPE after a pipe consumer exits early. Write command output through fallible helpers and treat BrokenPipe as normal termination. This allows commands such as show-translations to be safely piped to head. Signed-off-by: Dishendra Deshmukh <dishendra.deshmukh@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrokenPipeas normal command terminationProblem
Commands that produce large output panic when the pipe consumer exits
early. For example:
uefisettings show-translations | head -n 10headcloses the pipe after ten lines, and Rust'sprintln!macropanics when the following stdout write returns
EPIPE.Fix
Propagate stdout write errors through the command handlers and return
success when the error chain contains
BrokenPipe. Other I/O errorscontinue to use the existing command error path.
Validation
cargo test --bin uefisettingscargo test --libcargo run --quiet -- show-translations | head -n 10