hii: account for efivarfs attributes when reading varstores - #13
Open
dishendradeshmukh1986 wants to merge 1 commit into
Open
hii: account for efivarfs attributes when reading varstores#13dishendradeshmukh1986 wants to merge 1 commit into
dishendradeshmukh1986 wants to merge 1 commit into
Conversation
efivarfs prepends a 4-byte attributes field to each variable payload. VariableStore::read_bytes() allocated only the HII-declared payload size while extract_efi_data() skipped the attributes field, leaving the final four payload bytes unavailable. Read the attributes field together with the complete VarStore payload. Signed-off-by: Dishendra Deshmukh <dishendra.deshmukh@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
efivarfs exposes each variable as a 4-byte attributes field followed by
the variable payload.
VariableStore::read_bytes()allocated only theHII-declared payload size, while
extract_efi_data()skipped the firstfour bytes. This left the final four payload bytes unavailable and caused
ExtractEFIDataError: failed to fill whole bufferfor fields near the endof a VarStore.
Testing
cargo test --lib(10 passed)