pam: Use Box::from_raw - #563
Draft
A6GibKm wants to merge 1 commit into
Draft
Conversation
A6GibKm
force-pushed
the
box-from-raw
branch
from
September 1, 2026 19:24
2dd110e to
0a84ce1
Compare
Collaborator
|
This needs a rebase |
The password comes from a Box::into_raw so we reconstruct the Box to avoid it from leaking. See https://doc.rust-lang.org/std/boxed/struct.Box.html#method.into_raw.
A6GibKm
force-pushed
the
box-from-raw
branch
from
September 1, 2026 19:43
0a84ce1 to
8a2758e
Compare
Collaborator
Author
|
Done. |
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
Collaborator
|
was this checked beyond compilation btw? |
Collaborator
Author
|
I forgot to mention that I did not check it. Will do during the weekend. |
Collaborator
Author
|
Good thing that you asked, the cleanup_password might actually be taking care of that. |
A6GibKm
marked this pull request as draft
September 1, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password comes from a Box::into_raw so we reconstruct the Box to avoid it from leaking. See
https://doc.rust-lang.org/std/boxed/struct.Box.html#method.into_raw.