Skip to content

Propagate exclude credential - #213

Open
iinuwa wants to merge 4 commits into
mainfrom
propagate-exclude-credential
Open

Propagate exclude credential#213
iinuwa wants to merge 4 commits into
mainfrom
propagate-exclude-credential

Conversation

@iinuwa

@iinuwa iinuwa commented Aug 22, 2026

Copy link
Copy Markdown
Member

Fixes #211.

This is going to conflict with #204 though, so I'll wait until that lands to merge this.

@iinuwa
iinuwa requested a review from msirringhaus August 22, 2026 14:25
msirringhaus
msirringhaus previously approved these changes Aug 24, 2026

@msirringhaus msirringhaus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iinuwa
iinuwa force-pushed the propagate-exclude-credential branch from ad52d2e to d1b627f Compare August 26, 2026 05:31
@iinuwa

iinuwa commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Rebased, so this is a bit smaller now. I tested and this works to return to the error to the caller, but there's a follow-up needed from #204 to prevent sending a ErrorCancelled error right after the CredentialExcluded to the UI, so the window flashes from "This authenticator is already registered" to "Something went wrong."

Still need to add tests before merging

@iinuwa iinuwa added this to the 0.3 milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return InvalidStateError to caller

2 participants