perf(source-map): streamline range-query hot path - #120
Merged
Merged
Conversation
Select the segment map from the node type. Validate indices and bounds without allocating a closure. Closes #119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node.type.emptyCodeOffsetsonly for code nodes.Benchmark
The existing benchmark uses a text node and measures repeated range queries.
Text mappings already hit the first segment WeakMap before this change.
This case measures the validation and
emptyCodeOffsetschanges.It does not measure the reduced map probes for code nodes.
A representative 256 KiB
query every code unitrun changed from 12.32 ms to 11.13 ms.This result is a 9.7% reduction.
Same-process A/B runs showed approximately 10% to 25% gains for large repeated-query workloads.
Results below 2 ms changed significantly between runs due to JIT and timer noise.
This PR does not claim the observed 16 KiB result as a stable 52.9% improvement.
Single queries and small workloads will not show a material difference.
Build performance does not change.
Tests
pnpm testpnpm run buildnode scripts/bench-source-map.mjsCloses #119.