refactor: sanitize configPath in error messages and make resolveAdaptiveConcurrency sync - #196
Merged
luojiyin1987 merged 1 commit intoSep 13, 2026
Conversation
luojiyin1987
force-pushed
the
refactor/sanitize-configpath-and-sync-concurrency
branch
from
September 13, 2026 09:01
322618a to
53e38b3
Compare
P1: User-supplied configPath is now sanitized via sanitizeTerminalText() before embedding in terminal output. Linux filenames allow newlines and control characters, so unsanitized paths are a terminal-output correctness issue. P2: resolveAdaptiveConcurrency() was declared async but had no await, and took mdFilePaths: string[] but only used .length. Now sync, taking fileCount: number instead.
luojiyin1987
force-pushed
the
refactor/sanitize-configpath-and-sync-concurrency
branch
from
September 13, 2026 09:10
53e38b3 to
5ff6eda
Compare
luojiyin1987
deleted the
refactor/sanitize-configpath-and-sync-concurrency
branch
September 13, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 (correctness): User-supplied configPath is now sanitized via
sanitizeTerminalText()before embedding in terminal output.P2 (API clarity):
resolveAdaptiveConcurrency()was declared async but had no await, and tookmdFilePaths: string[]but only used.length. Now sync, takingfileCount: numberinstead.224 tests pass.
Closes #195