refactor(benchmark): measure the built CLI instead of tsx - #189
Merged
Merged
Conversation
benchmark-memory.mjs now runs: node lib/src/lint-md.js instead of: node tsx src/lint-md.ts This eliminates tsx runtime overhead and matches real npm usage. The worker thread path is now fully compiled JS, not a fallback. Also adds BSD-style /usr/bin/time output parsing as fallback. Requires `npm run build` before running the benchmark.
luojiyin1987
force-pushed
the
refactor/benchmark-built-cli
branch
from
September 13, 2026 05:28
5cc8f34 to
2aa5dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
benchmark-memory.mjs runs
node tsx src/lint-md.ts, but batchLint() worker falls back tolib/src/utils/lint-worker.jswhen the TypeScript source path is not found. This creates a mixed-mode benchmark:Real npm users run
node lib/src/lint-md.jsfor both. The tsx overhead biases absolute RSS and startup numbers.Solution
Run the built CLI directly:
Requires
npm run buildbefore running. The script now checks for the built CLI and throws if missing.Changes
/usr/bin/timeoutput parsing as fallbackVerification
Closes #190