TPT-4481: Implemented support for Configurable VPC IPv4 Prefixes#986
Draft
ezilber-akamai wants to merge 4 commits into
Draft
Conversation
ezilber-akamai
requested review from
psnoch-akamai and
zliang-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client- and test-support for configurable VPC IPv4 prefixes by modeling IPv4 ranges on VPCs, adding a client call for the new VPC default-ranges endpoint, and extending integration tests/fixtures to validate the new behavior and region capabilities.
Changes:
- Added IPv4 range structs/fields to VPC create/update models and a
GetVPCDefaultRangesclient method. - Added integration coverage for custom VPC IPv4 ranges capability and VPC default ranges.
- Updated region capability integration tests and refreshed recorded fixtures.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
vpc.go |
Adds IPv4 range models, default-ranges response model, and GetVPCDefaultRanges; updates create/update option structs. |
regions.go |
Adds CapabilityVPCCustomIPv4Ranges capability constant. |
test/integration/vpc_test.go |
Adds integration test covering VPC IPv4 range create/get/list/update plus default-ranges call. |
test/integration/regions_test.go |
Fixes region-capability assertions and adds test for “Custom VPC IPv4 Ranges” capability. |
test/integration/fixtures/TestVPC_IPv4DefaultRanges.yaml |
New fixture covering VPC IPv4 range workflow + /vpcs/default-ranges. |
test/integration/fixtures/TestRegions_pgLimits.yaml |
Updated regions fixture data for placement group limits test. |
test/integration/fixtures/TestRegions_kubernetesEnterprise.yaml |
Updated regions fixture data for Kubernetes Enterprise capability test. |
test/integration/fixtures/TestRegions_customVPCIPv4Ranges.yaml |
New fixture for Custom VPC IPv4 Ranges capability test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for the new
GET /v4/vpcs/default-rangesendpoint and updated the following endpoints to support IPv4:GET /v4/vpcs/<id>GET /v4/vpcsPOST /v4/vpcsPUT /v4/vpcs/<id>Also fixed some region capability integration tests that had meaningless assertions such that they actually check what they are meant to be checking for.
✔️ How to Test
Note that you will need appropriate customer tags for the tests to pass.
make test-int TEST_ARGS="-run TestVPC_IPv4DefaultRanges"make test-int TEST_ARGS="-run TestVPC_DefaultRanges"make test-int TEST_ARGS="-run TestRegions_customVPCIPv4Ranges"make test-int TEST_ARGS="-run TestRegions_pgLimits"make test-int TEST_ARGS="-run TestRegions_blockStorageEncryption"make test-int TEST_ARGS="-run TestRegions_kubernetesEnterprise"