TPT-3501: update existing tests to validate python sdk support nodebalancer lke cluster and type fields - #716
Open
psnoch-akamai wants to merge 5 commits into
Conversation
psnoch-akamai
requested review from
jriddle-linode and
mawilk90
and removed request for
a team
July 14, 2026 08:15
Contributor
|
Tests |
…test test_get_nb_with_lke_cluster
…test test_get_nb_with_lke_cluster
mawilk90
reviewed
Jul 27, 2026
|
|
||
|
|
||
| @pytest.fixture(scope="package") | ||
| def lke_cluster(test_linode_client): |
Contributor
There was a problem hiding this comment.
Could you please add a description to make it easier to distinguish lke_cluster and lke_cluster_instance ? Moreover, lke_cluster fixture needs to be imported in test_nodebalancers.py, otherwise the test test_get_nb_with_lke_cluster will fail
Contributor
Author
There was a problem hiding this comment.
Good point, thanks! I added import and rename function to be more descriptive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ How to Test