Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Moderate test issues must be corrected to verify the intended authorization behavior.
Review effort: Lite
Findings: None
What changed in this PR
Updates CloudTTY authorization to respect team useCloudShell settings for read and delete access.
Changes:
- Maps CloudTTY GET/DELETE operations to
useCloudShell. - Adds V1 and V2 authorization tests.
| File | Summary | Findings |
|---|---|---|
src/middleware/authz.ts |
Applies self-service authorization to CloudTTY operations. | None noted. |
src/api.authz.test.ts |
Adds V1 CloudTTY authorization coverage. | Two moderate findings: tests use the wrong team member token, bypassing the setting check. |
src/api-v2.authz.test.ts |
Adds V2 CloudTTY authorization coverage. | Moderate finding: fixtures do not set the required useCloudShell flags, so denial tests may return 200. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that creating a cloud shell as a regular user is currently broken on main. Need to run Core on linode/apl-core#3695 (APL-2191) for testing until merged.