Skip to content

fix: consider empty GIT_REPO_URL variable - #1043

Merged
j-zimnowoda merged 3 commits into
mainfrom
APL-2058
Aug 3, 2026
Merged

fix: consider empty GIT_REPO_URL variable#1043
j-zimnowoda merged 3 commits into
mainfrom
APL-2058

Conversation

@merll

@merll merll commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@merll
merll requested a review from ferruhcihan as a code owner August 3, 2026 13:50
Copilot AI review requested due to automatic review settings August 3, 2026 13:50
@merll
merll requested a review from dennisvankekem as a code owner August 3, 2026 13:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Git configuration initialization in OtomiStack to avoid runtime errors when GIT_REPO_URL is unset/empty, improving robustness of environment-based Git behavior selection.

Changes:

  • Guards env.GIT_REPO_URL.startsWith('file://') to prevent calling startsWith on an undefined value.
  • Minor import ordering adjustment in the Kubernetes client-node import list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/otomi-stack.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 3, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@j-zimnowoda
j-zimnowoda merged commit e5c186f into main Aug 3, 2026
9 checks passed
@j-zimnowoda
j-zimnowoda deleted the APL-2058 branch August 3, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants