test: avoid redundant cleanup after verified process exit - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
合并后 CI 34593556243 的 owner-death 报告已确认 9 个受管进程全部退出，survivors=[]，但 finally 仍逐个启动 PowerShell 做兜底终止，其中一次触发 8 秒 spawnSync ETIMEDOUT，导致成功场景在收尾时报错。
仅在验收已成功确认全部退出时省去重复终止。失败路径仍执行原有 PID/创建时间核对和清理，清理错误继续使验收失败；生产代码、超时和依赖不变。
验证：真实 owner-death 正常路径通过（run-HzZLg9）；使用临时脚本副本故意保留 Gateway，确认残留仍使验收失败、兜底清理实际执行，清理后所有已记录身份的进程均退出（run-LTW9Qh）。修改只涉及验收脚本的条件及现有工作记录。未宣称已确定 PowerShell 调用超时的底层原因。
最终提交 5e22285 的 Node 22/24 和 CodeQL 全部通过；已合并为 4720bf8。合并后的同一主分支提交也已通过 Node 22/24 CI 和 CodeQL。本地 main 与远端一致，工作区干净。