Skip to content

Validate missing link references#51

Merged
konard merged 5 commits intomainfrom
issue-15-d0c58a82
Apr 30, 2026
Merged

Validate missing link references#51
konard merged 5 commits intomainfrom
issue-15-d0c58a82

Conversation

@konard
Copy link
Copy Markdown
Member

@konard konard commented Sep 10, 2025

Summary

  • validate numeric and named references before applying LiNo query changes
  • keep references valid when the same operation explicitly creates the referenced numbered or named link
  • add --auto-create-missing-references to create missing references as self-referential point links
  • mirror the behavior in the C# and Rust implementations, with docs and release metadata updates

Tests

  • dotnet test csharp/Foundation.Data.Doublets.Cli.sln
  • dotnet build csharp/Foundation.Data.Doublets.Cli.sln --configuration Release
  • cargo test --manifest-path rust/Cargo.toml
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets --all-features
  • cargo fmt --manifest-path rust/Cargo.toml --all -- --check
  • node scripts/check-file-size.mjs --lang rust
  • git diff --check

Resolves #15

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #15
@konard konard self-assigned this Sep 10, 2025
konard and others added 2 commits September 10, 2025 17:21
…tent links

- Add validation to ensure link references either exist or will be created in the current operation
- Allow references to links that will become available after the operation (e.g., mutual references)
- Prevent invalid references to links that don't exist and won't be created
- Add comprehensive test coverage for the validation functionality
- Includes proper handling of variables, wildcards, and definitions vs references

Fixes #15

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Make it impossible to make a reference to a link, that does not exists Make it impossible to make a reference to a link that does not exist Sep 10, 2025
@konard konard marked this pull request as ready for review September 10, 2025 14:36
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

We should get latest changes from default branch. Make sure we we mirror all these features also to Rust version of code.

We should support multiple way to resolve that.

By default we throw error, and suggest to use --auto-create-missing-references, that should be created as point links (fully reference themselves only).

It should be supported for both numbered references and named references.

We need to ensure all changes are correct, consistent, validated, tested, logged and fully meet each and all discussed requirements in widest possible sense (check issue description and all comments in issue and in pull request, make sure each and every requirement listed before actually checking if they were addressed). Ensure all CI/CD checks pass.

Please plan and execute everything in a single pull request, you have unlimited time and context, as context autocompacts and you can continue indefinetely, do as much as possible in one go, until it is each and every requirement fully addressed, and everything is totally done.

@konard konard marked this pull request as draft April 30, 2026 07:08
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

🤖 AI Work Session Started

Starting automated work session at 2026-04-30T07:08:21.906Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard changed the title Make it impossible to make a reference to a link that does not exist Validate missing link references Apr 30, 2026
@konard konard marked this pull request as ready for review April 30, 2026 07:35
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

Solution summary

Implemented and pushed the fix to PR 51: #51

What changed:

  • C# and Rust now validate missing numeric and named references by default.
  • Added --auto-create-missing-references to create missing refs as self-referential point links.
  • Preserved valid references to links created by the same operation.
  • Added C# and Rust tests, docs, changeset/changelog entries.
  • Merged latest main; PR is now CLEAN and MERGEABLE.

Verification:

  • dotnet test csharp/Foundation.Data.Doublets.Cli.sln
  • dotnet build csharp/Foundation.Data.Doublets.Cli.sln --configuration Release
  • cargo test --manifest-path rust/Cargo.toml
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets --all-features
  • cargo fmt --manifest-path rust/Cargo.toml --all -- --check
  • node scripts/check-file-size.mjs --lang rust
  • git diff --check

GitHub CI is passing for both Rust and C# workflows on commit 81a5191. Working tree is clean.


This summary was automatically extracted from the AI working session output.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $20.671855

📊 Context and tokens usage:

  • 14.7M / 1.1M (1403%) input tokens, 69.1K / 128K (54%) output tokens

Total: (314.2K + 14.4M cached) input tokens, 69.1K output tokens, $20.671855 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (87045KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard merged commit 8cc538a into main Apr 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it impossible to make a reference to a link, that does not exists

1 participant