fix(#3069): reject placeholder JIRA keys in PR title checker by fullsend-ai-coder[bot] · Pull Request #3073 · lightspeed-core/lightspeed-stack

fullsend-ai-coder · 2026-10-29T16:40:27Z

Description

Replace the prefix-based prefixes check in .github/pr-title-checker-config.json with a regexp pattern that validates JIRA issue keys have a real, non-zero issue number. The thehanimo/pr-title-checker action supports regexp as a direct replacement for prefixes.

The issue number starts with a non-zero digit ([1-9]) followed by optional additional digits
The [release/ prefix continues to work via alternation
The failure message is updated to guide contributors

Also updates AGENTS.md to document the stricter validation and adds examples of rejected titles.

Type of change

CI configuration change

Tools used to create PR

Generated by: fullsend-code (pi runtime)

Validation criteria

PR title	Expected
`LCORE-5106: test`	pass
`RSPEED-2849: test`	pass
`[release/0.8] test`	pass
`LCORE-1 fix typo`	pass
`LCORE-0000: test`	fail
`LCORE-0: test`	fail
`LCORE-abc: test`	fail

Testing

Validated the regex pattern against all test cases from the issue using Python's re module. All cases pass correctly.

Closes #3069

Post-script verification

Branch is not main/master (agent/3069-reject-placeholder-jira-keys)
Secret scan passed (gitleaks — 401a7b55cd7f1561ef69e67ecbf9279e06c8e017..HEAD)
PR body secret scan passed (gitleaks — no-git)
Final PR description secret scan passed (gitleaks — no-git)

Replace the prefix-based check in pr-title-checker-config.json with a regexp pattern that requires a valid non-zero JIRA issue number after the project prefix. This rejects placeholder keys like LCORE-0000, LCORE-0, and LCORE-abc while continuing to accept valid keys like LCORE-5106 and RSPEED-2849. The [release/ prefix is preserved via regex alternation. Also updates AGENTS.md to document the stricter validation rules and adds examples of rejected placeholder keys. Closes #3069

coderabbitai · 2026-10-29T16:40:35Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: lightspeed-core/lightspeed-stack
Branch: main
File: .coderabbit.yaml
Commit: 401a7b5
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 772a069c-89c8-4428-b8d4-53e32ca31e29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

fullsend-ai-review · 2026-10-29T17:04:22Z

🤖 Finished Review · ✅ Success · Started 5:04 PM UTC · Completed 5:22 PM UTC

Commit: 3d4cd80 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.72

fullsend-ai-review · 2026-10-29T17:22:05Z

Risk Assessment: moderate (2/5)

Details

Unchanged from prior assessment. Tiny five-file config/docs change with clear issue alignment and trivial rollback. Protected path count (2) raises Tier 1 slightly, offset by minimal blast radius, small diff, bot author, and well-scoped issue.

Previous run

Risk Assessment: moderate (2/5)

Details

Tiny five-file config/docs change with clear issue alignment and trivial rollback. Protected path count (2) raises Tier 1 slightly, offset by minimal blast radius, small diff, bot author, and well-scoped issue.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Tiny two-file config/docs change with clear issue alignment and trivial rollback. Protected path count (2) raises Tier 1, offset by minimal blast radius, small diff, bot author, and well-scoped issue.

fullsend-ai-review · 2026-10-29T17:22:07Z

Review

Findings

Medium

[protected-path] .github/pr-title-checker-config.json, AGENTS.md — PR modifies protected files: .github/pr-title-checker-config.json (under .github/) and AGENTS.md. The PR links to issue PR title checker should reject placeholder JIRA keys like LCORE-0000 #3069 and explains the rationale for tightening PR title validation. Human approval is always required for protected-path changes, regardless of context.

Earlier findings

.github/pr-title-checker-config.json:7, pattern-inconsistency: reclassified from medium to info — tool-owned config file; format is dictated by the pr-title-checker action, not repository conventions
AGENTS.md:418, doc-style: resolved by change — incremental diff reformats the dense paragraph into a bullet list

Previous run

Review

Findings

Medium

[pattern-inconsistency] .github/pr-title-checker-config.json:7 — The regex enforces a [: ] delimiter (colon or space) immediately after the issue number, but none of the four documentation files (AGENTS.md, CONTRIBUTING.md, contributing_guidelines.md, contributing_guide.md) mention this requirement. A title like LCORE-1234-fix-bug would be silently rejected by the regex despite appearing to satisfy the documented rules.
Remediation: Either add a note to the documentation (e.g. "The JIRA key must be followed by a colon or space") or relax the regex delimiter.
[protected-path] .github/pr-title-checker-config.json, AGENTS.md — This PR modifies files under protected paths (.github/ and AGENTS.md). The PR links to issue PR title checker should reject placeholder JIRA keys like LCORE-0000 #3069 and the description explains the rationale. Human approval is always required for protected-path changes, regardless of context.

Low

[doc-style] AGENTS.md:418 — The "Allowed project prefixes" block is a single ~330-character paragraph packing three separate constraints (valid prefixes, positive-integer rule, leading-zero rejection) into one run-on sentence, whereas surrounding AGENTS.md sections use short bullet lists.

Earlier findings

AGENTS.md:415 stale-doc: resolved — AGENTS.md updated to document regex-based validation with non-zero issue number requirement
CONTRIBUTING.md:114 stale-doc: resolved — CONTRIBUTING.md updated to document new validation rules
docs/devel_doc/contributing_guide.md:101 stale-doc: resolved — contributing_guide.md updated to document new validation rules
docs/demos/lcore/contributing_guidelines.md:77 stale-doc: resolved — contributing_guidelines.md updated to document new validation rules

Next steps:

/fs-fix — agent addresses review findings automatically
/fs-fix <your instruction> — agent fixes with your specific guidance
Push commits directly — review re-runs automatically on push
/fs-fix-stop — disable automatic fix runs for this PR

Previous run (2)

Review

Findings

High

[stale-doc] CLAUDE.md:415 — CLAUDE.md still describes the old prefix-based prefixes check and lists "Allowed prefixes: LCORE-, RSPEED-, ...". The PR replaced prefixes with a regexp pattern that rejects placeholder keys (e.g. LCORE-0000). CLAUDE.md mirrors AGENTS.md content but was not updated in this PR.
Remediation: Apply the same wording changes made to AGENTS.md — replace "JIRA issue key prefix" with "valid JIRA issue key", replace the "Allowed prefixes" line with the project-prefix + positive-integer requirement description, and add rejection examples.
[stale-doc] CONTRIBUTING.md:114 — CONTRIBUTING.md still says "PR titles must start with a JIRA issue key prefix" and lists "Allowed prefixes: LCORE-, RSPEED-, ...". This no longer matches the regexp-based check and does not mention that placeholder keys like LCORE-0000 are rejected.
Remediation: Update lines 114–117 to reflect the new regexp-based validation, matching the updated AGENTS.md wording.

Medium

[stale-doc] docs/devel_doc/contributing_guide.md:101 — Developer contributing guide still references the old "Allowed prefixes" list and prefix-based check semantics. Does not mention regexp validation or placeholder-key rejection.
Remediation: Update lines 101–104 to match the new validation rules in the updated AGENTS.md.
[stale-doc] docs/demos/lcore/contributing_guidelines.md:77 — Demo contributing guidelines still list "Allowed prefixes: LCORE-, RSPEED-, ..." and describe a prefix-based check, now stale after the switch to regexp-based validation.
Remediation: Update lines 77–80 to reflect the new regexp-based PR title validation and placeholder-key rejection.
[pattern-inconsistency] .github/pr-title-checker-config.json:7 — The regexp requires [: ] immediately after the issue number, so a bare key like LCORE-123 with no trailing colon or space is rejected. This is stricter than the old prefixes mode. Ensure this is intentional; if bare keys should be allowed, use ([: ]|$) instead of [: ].
[protected-path] .github/pr-title-checker-config.json, AGENTS.md — PR modifies files under protected paths (.github/, AGENTS.md). The linked issue PR title checker should reject placeholder JIRA keys like LCORE-0000 #3069 explains the rationale for these changes. Human approval is required for protected-path changes regardless of context.

Low

[doc-style] AGENTS.md:415 — The updated text says "Placeholder keys like LCORE-0000 or LCORE-0 are rejected", but the regexp [1-9]\d* also rejects keys with leading zeros (e.g. LCORE-0123). Minor documentation omission.

Labels: PR modifies CI configuration and documentation files.

Next steps:

/fs-fix — agent addresses review findings automatically
/fs-fix <your instruction> — agent fixes with your specific guidance
Push commits directly — review re-runs automatically on push
/fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-coder · 2026-10-29T17:29:44Z

🤖 Finished Fix · ✅ Success · Started 5:29 PM UTC · Completed 5:35 PM UTC

Commit: 3d4cd80 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.40

Update CONTRIBUTING.md, docs/devel_doc/contributing_guide.md, and docs/demos/lcore/contributing_guidelines.md to reflect the new regexp-based PR title validation that rejects placeholder keys. Also document leading-zero rejection (e.g. LCORE-0123) in AGENTS.md since the regexp [1-9]\d* inherently rejects those. Disagree: CLAUDE.md is a symlink to AGENTS.md, already updated. Disagree: [: ] in regexp is intentional, requiring a description after the JIRA key. Addresses #3073

fullsend-ai-coder · 2026-10-29T17:35:58Z

🔧 Fix agent — iteration 1 (bot-triggered)

Updated three stale documentation files (CONTRIBUTING.md, docs/devel_doc/contributing_guide.md, docs/demos/lcore/contributing_guidelines.md) to reflect the new regexp-based PR title validation. Also documented leading-zero rejection in AGENTS.md. Disagreed on CLAUDE.md (it is a symlink to AGENTS.md, already updated), on the [: ] pattern (intentional to require descriptions), and acknowledged the protected-path merge gate.

Fixed (4):

CONTRIBUTING.md still uses old prefix-based wording and does not mention placeholder-key rejection (CONTRIBUTING.md): Updated PR description section to reflect the new regexp-based validation, matching AGENTS.md wording with positive-integer requirement, rejection examples, and leading-zero note.
Developer contributing guide still references old prefix-based check semantics (docs/devel_doc/contributing_guide.md): Updated PR description section to match the new validation rules, including positive-integer requirement, rejection examples, and leading-zero note.
Demo contributing guidelines still list old prefix-based check and are stale after regexp switch (docs/demos/lcore/contributing_guidelines.md): Updated PR description section to reflect the new regexp-based PR title validation with rejection examples and leading-zero note.
AGENTS.md documentation says placeholder keys are rejected but does not mention leading-zero rejection (AGENTS.md): Added note that keys with leading zeros (e.g. LCORE-0123) are also rejected by the [1-9]\d* pattern.

Disagreed (3):

CLAUDE.md still describes the old prefix-based check and needs updating: CLAUDE.md is a symlink to AGENTS.md, which was already updated in this PR. No separate change is needed.
The regexp requires [: ] after the issue number, rejecting bare keys with no trailing colon or space: The [: ] requirement is intentional. PR titles should always include a description after the JIRA key. A bare key like LCORE-123 with no description is not a useful PR title. The old prefix mode also effectively required content after the prefix since it matched prefixes like LCORE- and any real PR would have more text.
PR modifies files under protected paths (.github/, AGENTS.md) — human approval required: This is the merge-gate finding. Human approval is required for protected-path changes — acknowledged. No content edit prescribed by this finding.

Tests: passed

CI inspections (14):

PR Title Checker (unrelated, failure): Fails because the PR title itself uses a non-JIRA prefix format. This is a meta issue with the PR about the checker, not caused by the code changes. Expected for this PR. No action needed.
Black (passing, success)
Pyright (passing, success)
Ruff (passing, success)
Python linter (passing, success)
Pydocstyle (passing, success)
Shell check (passing, success)
Integration tests (passing, success)
Bandit security scanner (passing, success)
Check dependencies (passing, success)
Check image building (passing, success)
Radon (passing, success)
Type checks (passing, success)
OpenAPI (Spectral) (passing, success)

Conflict update: skipped; strategy none; forge MERGEABLE; target main

Decision points

Whether to change [: ] to ([: ]|$) in the regexp to allow bare JIRA keys (alternatives: Change to ([: ]|$) to allow bare keys, Keep [: ] to require a description after the key; rationale: Bare JIRA keys without any description are not useful PR titles. The current behavior is intentional and encourages descriptive PR titles.)

Next steps:

/fs-review — request a re-review of the changes
/fs-fix <your instruction> — run another fix pass with specific guidance
Push commits directly — review re-runs automatically on push
_{Updated by fullsend fix agent}

fullsend-ai-review · 2026-10-29T17:48:45Z

🤖 Finished Review · ✅ Success · Started 5:48 PM UTC · Completed 6:09 PM UTC

Commit: a7afa21 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.52

fullsend-ai-coder · 2026-10-29T18:11:25Z

🤖 Finished Fix · ✅ Success · Started 6:11 PM UTC · Completed 6:17 PM UTC

Commit: a7afa21 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.30

…3073) Document that the JIRA key must be followed by a colon or space after the issue number, matching the regex [: ] in pr-title-checker-config.json. AGENTS.md: refactored the run-on paragraph into a bullet list for readability and added an example of a rejected title missing the delimiter. CONTRIBUTING.md, contributing_guide.md, contributing_guidelines.md: added the delimiter note inline. Addresses #3073

fullsend-ai-coder · 2026-10-29T18:17:09Z

🔧 Fix agent — iteration 2 (bot-triggered)

Addressed the pattern-inconsistency finding by documenting the colon-or-space delimiter requirement across all four documentation files. Also addressed the doc-style finding by refactoring the AGENTS.md paragraph into a bullet list. The protected-path finding only requires human approval at merge time.

Fixed (5):

Regex enforces colon-or-space delimiter after issue number but documentation does not mention this requirement (AGENTS.md): Documented the colon-or-space delimiter requirement and refactored the run-on paragraph into a bullet list for readability. Added a rejected-title example showing a missing delimiter.
Regex enforces colon-or-space delimiter after issue number but documentation does not mention this requirement (CONTRIBUTING.md): Added note that the JIRA key must be followed by a colon or space.
Regex enforces colon-or-space delimiter after issue number but documentation does not mention this requirement (docs/devel_doc/contributing_guide.md): Added note that the JIRA key must be followed by a colon or space.
Regex enforces colon-or-space delimiter after issue number but documentation does not mention this requirement (docs/demos/lcore/contributing_guidelines.md): Added note that the JIRA key must be followed by a colon or space.
Allowed project prefixes paragraph uses a run-on sentence instead of bullet list formatting consistent with surrounding AGENTS.md sections (AGENTS.md): Refactored the single long paragraph into a bullet list, consistent with the formatting used in surrounding sections.

Disagreed (1):

PR modifies files under protected paths (.github/ and AGENTS.md) — human approval required: This is a protected-path category finding that only requires human reviewer approval at merge time. No content change is prescribed.

Tests: passed

CI inspections (3):

PR Title Checker / check (unrelated, failure): The PR title uses a non-standard format that does not match the new regex. This is an inherent issue with the PR title itself, not caused by these documentation changes. Update the PR title to use a valid JIRA key format.
E2E Tests (pending, pending): E2E tests are still running. These tests are infrastructure/integration tests unrelated to documentation-only changes.
Red Hat Konflux (pending, pending): Konflux pipeline queued. Unrelated to documentation changes.

Decision points

Whether to relax the regex delimiter or document it (alternatives: Relax the regex to allow any character after the issue number, Document the existing colon-or-space requirement; rationale: Documenting the delimiter is the safer choice: the colon-or-space convention is intentional and matches standard JIRA key usage. Relaxing the regex could allow unintended title formats.)

Next steps:

/fs-review — request a re-review of the changes
/fs-fix <your instruction> — run another fix pass with specific guidance
Push commits directly — review re-runs automatically on push
_{Updated by fullsend fix agent}

fullsend-ai-review · 2026-10-29T18:23:03Z

🤖 Finished Review · ✅ Success · Started 6:23 PM UTC · Completed 6:43 PM UTC

Commit: c6311de · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.79

Superseded by updated review

fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Oct 29, 2026

fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 29, 2026

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added documentation Improvements or additions to documentation Review effort 1/5 labels Oct 29, 2026

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Oct 29, 2026

Conversation

fullsend-ai-coder Bot commented Oct 29, 2026

Description

Type of change

Tools used to create PR

Validation criteria

Testing

Post-script verification

Uh oh!

coderabbitai Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

fullsend-ai-review Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Findings

Medium

Earlier findings

Review

Findings

Medium

Low

Earlier findings

Review

Findings

High

Medium

Low

Uh oh!

This comment was marked as outdated.

Uh oh!

fullsend-ai-coder Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-coder Bot commented Oct 29, 2026

🔧 Fix agent — iteration 1 (bot-triggered)

Uh oh!

fullsend-ai-review Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

fullsend-ai-coder Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-coder Bot commented Oct 29, 2026

🔧 Fix agent — iteration 2 (bot-triggered)

Uh oh!

fullsend-ai-review Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-review Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-review Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-review Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-coder Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-review Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-coder Bot commented Oct 29, 2026 •

edited

Loading

fullsend-ai-review Bot commented Oct 29, 2026 •

edited

Loading