Skip to content

LCORE-5106: regenerated rpm lock yaml for lightspeed stack (0.8.0rc1) - #3025

Open
snuryyeva wants to merge 1 commit into
lightspeed-core:mainfrom
snuryyeva:snuryyeva/CVE_fix
Open

snuryyeva wants to merge 1 commit into
lightspeed-core:mainfrom
snuryyeva:snuryyeva/CVE_fix

Conversation

@snuryyeva

@snuryyeva snuryyeva commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Updated the base images used for builds and runtime environments.
    • Removed Python packages from the configured package set. The corresponding package entries are no longer present for supported architectures.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 634d32e and 9ab43b5.

Files selected for processing: 3
  • .konflux/build-args-konflux.conf
  • .konflux/rpms.in.yaml
  • .konflux/rpms.lock.yaml
Files with no reviewable changes: 2
  • .konflux/rpms.lock.yaml
  • .konflux/rpms.in.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 27
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: unit_tests (3.14)
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: integration_tests (3.14)
  • GitHub Check: Pylinter
  • GitHub Check: build-pr
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
Additional comments: 1
.konflux/build-args-konflux.conf: 1

1-1: LGTM!

Also applies to: 3-3

Walkthrough

The Konflux build configuration updates the builder and runtime base images and removes python3 and python3-libs from the upgrade package list and RPM lockfile.

Changes

Konflux build inputs

Layer / File(s) Summary
Base image tags
.konflux/build-args-konflux.conf
The builder and runtime base image tags change to cpu:3.5.5-1793018691. The DNF command remains unchanged.
RPM package removal
.konflux/rpms.in.yaml, .konflux/rpms.lock.yaml
The upgrade package list is empty. The lockfile removes the python3 and python3-libs entries for aarch64 and x86_64.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested reviewers: tisnik, jrobertboos

Merge Risk: Minimal · up to 9ab43

No merge-blocking regression is established. Normal authenticated build validation should confirm the new image tag.

Pre-merge checks: Passed 7
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the RPM lockfile regeneration for the Lightspeed stack. This matches the primary change and uses specific project context.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity Passed PASSED. The pull request changes only Konflux base-image references and RPM input/lock files. It removes two locked Python packages and adds no algorithms, loops, API calls, list operations, caches, w…
Security And Secret Handling Passed PASSED. The PR changes only base-image references and RPM configuration/lock data. The added image lines contain no credentials, and the lockfile changes remove python3 package entries. No API endpo…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Performance And Algorithmic Complexity

Explanation

PASSED. The pull request changes only Konflux base-image references and RPM input/lock files. It removes two locked Python packages and adds no algorithms, loops, API calls, list operations, caches, watchers, buffers, or endpoints. No meaningful performance regression matches the check criteria.

Full details: Security And Secret Handling

Explanation

PASSED. The PR changes only base-image references and RPM configuration/lock data. The added image lines contain no credentials, and the lockfile changes remove python3 package entries. No API endpoint, authentication, secret, command, SQL, path, response, log, or Kubernetes Secret/OwnerReference changes appear in the reviewed diff.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jrobertboos jrobertboos changed the title LCORE-5106: regenerated rpm lock yaml for lightspeed stack LCORE-5106: regenerated rpm lock yaml for lightspeed stack (0.8.0rc1) Oct 26, 2026
@tisnik

tisnik commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

/test

@openshift-ci

openshift-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown

@tisnik: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants