scripts: allow tagging upstream release branches - #11047
Draft
ziggie1984 wants to merge 1 commit into
Draft
Conversation
🟢 PR Severity: LOW
🟢 Low (1 files)
AnalysisThis PR only modifies To override, add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--branchselect and tag the fetched upstream branch tipbuild/version.gofrom the exact commit that will be taggedHEADMotivation
Older release branches do not contain
scripts/tag-release.sh. Previously,checking out such a branch made the helper unavailable, while passing
--branchfrommasteronly compared that branch with the currentHEADandfailed. The helper can now remain on
masterand safely tag the verified tip ofan older upstream release branch.
Validation
bash -n scripts/tag-release.shgit diff --check--branch v0.20.x-branchwith an intentionally mismatchedtag and confirmed it read
v0.20.3-beta.rc1from the upstream branch withoutcreating a tag
HEADpath with an intentionallymismatched tag and confirmed version validation still rejects it