Skip to content

scripts: allow tagging upstream release branches - #11047

Draft
ziggie1984 wants to merge 1 commit into
lightningnetwork:masterfrom
ziggie1984:tag-release-upstream-branch
Draft

scripts: allow tagging upstream release branches#11047
ziggie1984 wants to merge 1 commit into
lightningnetwork:masterfrom
ziggie1984:tag-release-upstream-branch

Conversation

@ziggie1984

Copy link
Copy Markdown
Collaborator

Summary

  • make an explicit --branch select and tag the fetched upstream branch tip
  • read build/version.go from the exact commit that will be tagged
  • preserve the existing no-flag behavior, which verifies and tags the current HEAD
  • fetch a fully qualified branch ref without implicitly fetching tags

Motivation

Older release branches do not contain scripts/tag-release.sh. Previously,
checking out such a branch made the helper unavailable, while passing
--branch from master only compared that branch with the current HEAD and
failed. The helper can now remain on master and safely tag the verified tip of
an older upstream release branch.

Validation

  • bash -n scripts/tag-release.sh
  • git diff --check
  • exercised explicit --branch v0.20.x-branch with an intentionally mismatched
    tag and confirmed it read v0.20.3-beta.rc1 from the upstream branch without
    creating a tag
  • exercised the original no-flag/current-HEAD path with an intentionally
    mismatched tag and confirmed version validation still rejects it

@ziggie1984 ziggie1984 self-assigned this Aug 7, 2026
@github-actions github-actions Bot added the severity-low Best-effort review label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🟢 PR Severity: LOW

file classification | 1 files | 85 lines changed

🟢 Low (1 files)
  • scripts/tag-release.sh - build/release tooling script, not application code

Analysis

This PR only modifies scripts/tag-release.sh, a release tooling script. It does not touch any wallet, channel, HTLC, peer, or other consensus/fund-handling code paths, so it qualifies as best-effort review under the LOW severity tier. No severity bump conditions apply (single file, no critical packages touched).


To override, add a severity-override-{critical,high,medium,low} label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity-low Best-effort review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant