lnwallet+lnwire: handle boundary cases - #11035
Open
yyforyongyu wants to merge 3 commits into
Open
Conversation
Return both completion results when the reservation is no longer present. Add a focused regression test for the missing-reservation response.
Define LastBlockHeight for zero-length query and reply ranges. Return the first block height when the range is empty. Cover empty, normal, and overflowing ranges for both message types.
yyforyongyu
force-pushed
the
fix-p2p-wedges
branch
from
August 6, 2026 14:08
cc78907 to
a0cafac
Compare
Document the channel funding and channel range boundary fixes for the v0.21.3 maintenance release.
yyforyongyu
force-pushed
the
fix-p2p-wedges
branch
from
August 6, 2026 14:12
a0cafac to
bb7ff27
Compare
🔴 PR Severity: CRITICAL
🔴 Critical (3 files)
🟢 Low (3 files)
AnalysisThis PR touches both To override, add a |
yyforyongyu
marked this pull request as ready for review
August 7, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Make channel funding completion return both results when its pending wallet
reservation is no longer present. Define the last block height for zero-length
query and reply channel ranges while preserving existing non-empty and
overflow behavior.
Add focused regression coverage and a v0.21.3 release note.
Steps to Test
Pull Request Checklist
Testing
Code Style and Documentation
Please see the contribution guidelines for further guidance.