Skip to content

Retry transient Kotlin channel closures #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinewallace merged 1 commit into from
Aug 19, 2026
+15 −1
Merged

Retry transient Kotlin channel closures #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,20 @@ fun waitForBlock(esploraEndpoint: String, blockHash: String) {
}
}

fun closeChannelWithRetry(closeChannel: () -> Unit) {
repeat(50) { attempt ->
try {
closeChannel()
return
} catch (exception: NodeException.ChannelClosingFailed) {
if (attempt == 49) {
throw exception
}
Thread.sleep(100)
}
}
}

class CustomLogWriter(private var currentLogLevel: LogLevel = LogLevel.INFO) :
LogWriter {
enum class LogLevel {
Expand Down Expand Up @@ -304,7 +318,7 @@ class LibraryTest {
assert(node1.listPayments().size == 3)
assert(node2.listPayments().size == 2)

node2.closeChannel(userChannelId, nodeId1)
closeChannelWithRetry { node2.closeChannel(userChannelId, nodeId1) }

val channelClosedEvent1 = node1.waitNextEvent()
println("Got event: $channelClosedEvent1")
Expand Down
Loading