Prevent Electrum updates during shutdown - #1054
Open
tnull wants to merge 1 commit into
Open
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
Contributor
|
Needs rebase |
A timed-out synchronous Electrum sync can outlive its driving task and continue calling Confirm implementations while node shutdown is draining persistence work. Close a gate before task cancellation so no new callbacks can start. Let callbacks already in progress finish atomically before shutdown continues. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-08-electrum-shutdown-safety
branch
from
August 19, 2026 06:19
d392a8b to
3e40819
Compare
Collaborator
Author
Rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #997 for now, will rebase once that's merged.