Repository navigation
Conversation
why: Native call forms linked local arguments and fragments of var names to unrelated Java APIs. what: - Preserve complete Clojure var and argument tokens. - Mark native call names and parameters as declarations. - Retain authored references and Java type-hint links. - Cover colliding names through the actual symbol resolver.
why: Native signature rendering must preserve callable names and keep local arguments out of the Java parent inventory. what: - Render every public Clojure function arity through Astro. - Check copied source text, declaration names and link destinations.
why: The corrected renderer removes 53 spurious signature links and adds one valid namespace link, taking the measured count from 695 to 643. All 311 references outside signatures remain unchanged. The old minimum of 673 counted declaration and binding links that should never resolve. what: - Set only the Clojure cross-reference minimum to the measured 643 - Keep every other port minimum and the shared checker unchanged
tony
force-pushed
the
fix/clojure-signature-bindings
branch
from
November 10, 2026 09:53
2d32668 to
f58c5b5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
(send! connection argv timeout),timeoutlinked to Java'sCommandRequest.timeout. The tokenizer also splitjoin-pane!andone-or-noneinto fragments and linked those fragments to unrelated methods. Native Clojure call forms now identify the public var and its local bindings before generic symbol lookup.The renderer regression exercises all 85 public functions and 98 arities with the actual Java parent inventory. Other language branches retain their existing behavior.
Test plan
timeoutlink with the original renderer.git diff --check.856211d85; pass the focused model, renderer, type and ratchet checks.pnpm testfailed after 40.96 seconds: 1,454 model tests passed and 14 skipped, but the full-corpus resolver test exceeded its unchanged five-second timeout (11.11 seconds under parallel load). Pending checks were stopped. Earlier isolated success is not a broad pass; no timeout or loop budget is increased.This draft targets current docs main. Coordinate landing with the shared docs release; the
no-previewlabel holds preview publication.Local publisher qualification uses an unpublished integration commit,
7cf7d80f20cc8dea8437f51342b2c794fb91cde8, combining PR #296 at0149aad1with this fix at2d326686e. It renders 124 Clojure pages, including 92 reference pages, from clean source records. The production type-link checker reports six linked types and five plainnskeyword tokens. All native call forms are free of unrelated Java links. This local result leaves full shared CI and publication of this renderer fix pending. The r19 baseline documentation is already publicly published; it does not contain this follow-up fix.The browser check of that same build passes 16 page/width combinations in 6.52 seconds, including the real shared native-header geometry checks. The picker places Clojure with Java, Kotlin and Scala; filtering, Escape and focus return work. Covered controls and an injected false Java link are rejected, then restored. Chromium closes with no remaining owned process. Firefox failed at startup and supplies no rendering evidence. External requests are blocked or replaced by the shared checker; other ports and public deployment remain outside this check.
The original hosted run failed at the Clojure cross-reference minimum: 643
against 673. The before/after output measures 695 → 643 because 39 Java
links and 14 own-symbol/partial-prefix links inside signatures disappear,
while the corrected
libtmux.core-asyncnamespace contributes one validlink. All 311 references outside signatures are identical. Set the Clojure
minimum to the measured 643; retain the shared checker and every other
port’s record. A deliberate one-count shortfall still fails.
The rebase preserves both original patches exactly. The linker is byte-for-byte
identical to the already-qualified local publisher input; the new commit only
updates the measured Clojure minimum. The outer failure above remains open,
and this PR remains a draft while its new hosted CI run is pending.