Repository navigation
Conversation
why: Staging the Common Lisp guides at libtmux-lisp 13449ad failed with "Common Lisp declaration has no native reference: libtmux.control:await-request". The package-to-file table had no entry for libtmux.control, which documents itself in docs/control-api.md. Docs CI passed because the committed lisp.json model predates that package; only the port build, which regenerates the model at the port head, saw it. what: - Add libtmux.control -> docs/control-api.md to the table, now exported as LISP_REFERENCE_FILES. It was the only public package missing; the other five match the packages in the port's documentation artifact list. - Add a stage-port-docs test that reads the package list from the lisp checkout (LIBTMUX_DOCS_CHECKOUT_LISP) and requires each package to map to a reference file with declaration anchors, and each committed-model declaration to find its anchor in that file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8245169onCommon Lisp declaration has no native reference: libtmux.control:await-request.libtmux.controltodocs/control-api.mdin the Lisp package table ofscripts/stage-port-docs.mjs.Cause
The Lisp branch of
stagedPortGuidesmaps each package to its native reference file through a fixed table. libtmux-lisp documentslibtmux.controlindocs/control-api.md(anchors such asawait-request-function), but the table had no row for it. Docs CI passed because the committedsite/src/data/api/lisp.jsonpredates that package; the port's build regenerates the model at the port's head, so only libtmux-lisp's docs runs saw it: run 42755820881 at13449adand run 42756204772 ata893752.Changes
scripts/stage-port-docs.mjs: the table becomes the exportedLISP_REFERENCE_FILES, with thelibtmux.controlrow. libtmux-lisp'stools/documentation.lisplists six public packages at13449ad; this was the only one missing.site/test/stage-port-docs.test.ts: reads the package list from the CI checkout of libtmux-lisp (LIBTMUX_DOCS_CHECKOUT_LISP), and asserts each package maps to a file with declaration anchors and each model symbol's anchor exists in its mapped file. It runs against the checkout at the model revision, so it catches a new package when that revision moves.Test plan
libtmux.controlrow (checkout at13449ad) and passes with itstage-port-docs.mjs --from-source --port lispagainst libtmux-lisp13449adwith a regenerated model: the error before,15 guides from lispafter