Replace throws -> raises#423
Open
james-d-mitchell wants to merge 3 commits intolibsemigroups:stable-1.4from
Open
Replace throws -> raises#423james-d-mitchell wants to merge 3 commits intolibsemigroups:stable-1.4from
james-d-mitchell wants to merge 3 commits intolibsemigroups:stable-1.4from
Conversation
Merged
Joseph-Edwards
requested changes
May 1, 2026
Collaborator
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
There was a problem hiding this comment.
This looks good to me, though there are some more examples of "throws" in forest.cpp and present.cpp. If we could make the same changes in these files, then I would be happy to merge. Thanks @james-d-mitchell!
james-d-mitchell
force-pushed
the
throws-becomes-raises
branch
from
9788669 to
9a01ece
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.