Repository navigation
Conversation
BKPepe
force-pushed
the
fix/probe-status-first
branch
from
November 19, 2026 08:21
5729c64 to
0c69f59
Compare
RUSTSEC-2026-0543 marks chrono unmaintained, which fails cargo deny in Audit and in the release workflow. The time crate reads the local time instead, with the same output, except that an invalid TZ or a zone OpenWrt has not yet linked to /etc/localtime now means UTC, as in the Go client.
The specification asks the build to fail instead, as clang already does, so a packaging mistake no longer passes for a reproducible build.
A ping answer that hung up or timed out mid-body was reported by the failed read, so its 404 or 500 went unnamed. The status now comes first, and a failed read of a 200 says "reading the ping response:", as in the Go client.
ServerStatus kept up beside down_reason, and the run kept a measured flag beside its list of down servers, so either pair could disagree. Both now follow from the reason, which also drops a duplicated label and a null report no run reaches.
The README still listed an 8 KiB cap on the check that a backend is up, which now reads 512 bytes like the Go client. A test comment also named reqwest instead of hyper.
The crate exposes its modules so the binary, the tests and the fuzz targets can share them, and releases have already changed them in ways semver calls breaking. The README and the crate docs now say so.
BKPepe
force-pushed
the
fix/probe-status-first
branch
from
November 19, 2026 17:43
0c69f59 to
e5d6b76
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six commits to land before 1.3.0.
cargo denyin Auditand the release workflow. time 0.3.37 or newer now reads the local time, with
the same output as chrono on millions of values and as Go on its golden
timestamps. An invalid
TZ, or an OpenWrt zone not yet linked to/etc/localtime, now means UTC, as in the Go client. On 32-bit musl the libccrate still has a 32-bit
time_t, so there the time falls back to UTC from2038. The native-tls build without http2 is 33 kB smaller.
SOURCE_DATE_EPOCH, an empty one included, fails the build, asthe specification asks and clang does, instead of giving it today's date.
404 or 500 went unnamed. The probe now follows Go's
CheckUp: the statusfirst, then the failed read as "reading the ping response:", then a non-empty
body. The request and the body read share one deadline, as under Go's client
timeout. New parity cases run truncated, stalled and chunked 404 and 200
answers, a 204 and a long body against Go 8aefd77.
ServerStatusderivesup()fromdown_reason, and the run drops itsmeasuredflag, a duplicated label and a null report no run reaches.library API can change in any release. 1.3.0 changes it again (
get_prefix,ServerStatus,format_timestamp), as 1.2.1 did.Tested on e5d6b76: cargo test with rustls-tls and native-tls, each with and
without http2, on macOS and Debian, parity against Go 8aefd77, clippy, cargo
deny, cargo publish --dry-run and a check of each set with Rust 1.93.1. Known
failures on master too: tests/alpn.rs with native-tls on macOS and the help
parity case without http2. The local time in OpenWrt 25.12 on aarch64 against
1.2.1 and Go and on armv7, with and without zoneinfo and with a POSIX rule in
TZ.