Repository navigation
fix: fail the run when no selected server answers - #21
Merged
Merged
Conversation
When all selected servers are down, or there is none to test, exit 1 and report each server's failure to stderr instead of emitting an empty report. Runs with at least one successful server still exit 0. As in the Go client, the probe reads at most 512 bytes of the ping response and names a wrong status with Go's reason phrase. The parity test now runs against the Go commit with the same fix.
BKPepe
force-pushed
the
fix/unreachable-server-exit
branch
from
November 14, 2026 17:50
b5cc4a4 to
7a31f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every selected server is unreachable (for example a cached
--local-jsonlist on a link that is down), the client printed an emptyreport and exited 0, so a wrapper could not tell why the measurement
failed. The run now exits 1 and names each server's failure on stderr,
and a run with no server to test (
--server -1with an empty list) failstoo. Runs with at least one successful server still exit 0.
This is librespeed/speedtest-cli#153 for the Rust client, down to the
512-byte probe read and Go's reason phrases in the error. The parity test
now pins the Go commit that merged it, so the behaviour is compared with
Go's instead of being declared a difference.
ServerStatusgainsdown_reason, so code that builds it with every field listed needs thenew one.