Skip to content

fix: fail the run when no selected server answers - #21

Merged
BKPepe merged 1 commit into
masterfrom
fix/unreachable-server-exit
Nov 14, 2026
Merged

BKPepe merged 1 commit into
masterfrom
fix/unreachable-server-exit

Conversation

@BKPepe

@BKPepe BKPepe commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

When every selected server is unreachable (for example a cached
--local-json list on a link that is down), the client printed an empty
report and exited 0, so a wrapper could not tell why the measurement
failed. The run now exits 1 and names each server's failure on stderr,
and a run with no server to test (--server -1 with an empty list) fails
too. Runs with at least one successful server still exit 0.

This is librespeed/speedtest-cli#153 for the Rust client, down to the
512-byte probe read and Go's reason phrases in the error. The parity test
now pins the Go commit that merged it, so the behaviour is compared with
Go's instead of being declared a difference. ServerStatus gains
down_reason, so code that builds it with every field listed needs the
new one.

Copilot AI lite review requested due to automatic review settings September 27, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

When all selected servers are down, or there is none to test, exit 1
and report each server's failure to stderr instead of emitting an
empty report. Runs with at least one successful server still exit 0.

As in the Go client, the probe reads at most 512 bytes of the ping
response and names a wrong status with Go's reason phrase. The parity
test now runs against the Go commit with the same fix.
@BKPepe
BKPepe force-pushed the fix/unreachable-server-exit branch from b5cc4a4 to 7a31f1b Compare November 14, 2026 17:50
@BKPepe
BKPepe merged commit 3eb3038 into master Nov 14, 2026
16 checks passed
@BKPepe
BKPepe deleted the fix/unreachable-server-exit branch November 17, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants