fix: publish Linux asset in 1.1.15 release - #26
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16e8c23350
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| chmod 755 "$asset" | ||
| if readelf --program-headers --wide "$asset" | grep -F 'Requesting program interpreter'; then | ||
| echo 'Linux release binary is dynamically linked' >&2 | ||
| if readelf --program-headers --wide "$asset" | grep -E 'Requesting program interpreter: .*/ld-linux[^]]*'; then |
There was a problem hiding this comment.
When the produced ELF contains the /lib/ld-musl-x86_64.so.1 interpreter that prompted this change, this predicate now publishes a dynamically loaded binary rather than the advertised static Linux asset. The subsequent "./$asset" version check passes only because this job installs musl-tools, which provides that loader; on a typical glibc-only Linux installation the kernel fails before the CLI starts because the interpreter is absent. Keep rejecting any PT_INTERP entry or adjust the build flags so the artifact is genuinely static.
Useful? React with 👍 / 👎.
|
Addressed the P1 concern in commit @codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The P1 concern is now addressed with a locally reproduced and CI-verified fix:
Local static-pie build and @codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
ld-linux) dependencies1.1.15The previous
v1.1.14release built the Linux binary but rejected it because the validation treated the musl interpreter as an error.Validation
cargo fmt --all -- --checkcargo test --all-targets --locked(14 passed)cargo clippy --all-targets --locked -- -D warnings