Statically link the Windows C runtime - #23
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Windows “release” validation path to CI and configures Rust builds for MSVC to use a statically linked CRT, aiming to ensure the produced browser-cli.exe runs without requiring the Visual C++ Redistributable.
Changes:
- Add a new
windows-releaseGitHub Actions job to build/test a Windows MSVC release binary and inspect its DLL dependencies. - Add
.cargo/config.tomlto enable+crt-staticforx86_64-pc-windows-msvc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds a Windows release job with a dependency check for dynamic VC++ runtime DLLs. |
| .cargo/config.toml | Forces static CRT linking for the Windows MSVC target used by the new CI job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Verify standalone Windows executable | ||
| shell: powershell | ||
| run: | | ||
| $binary = "target/x86_64-pc-windows-msvc/release/browser-cli.exe" |
Comment on lines
+103
to
+106
| $installationPath = & $vswhere -latest -property installationPath | ||
| Import-Module "$installationPath\Common7\Tools\Microsoft.VisualStudio.DevShell.dll" | ||
| Enter-VsDevShell -VsInstallPath $installationPath -SkipAutomaticLocation | ||
| $dependencies = & dumpbin.exe /dependents $binary |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The published v1.1.12 Windows binary fails on a clean Windows x64 machine with exit code 0xC0000135. Its PE import table includes VCRUNTIME140.dll, so both the Skill bootstrap and @lexmount/dsh-browser download a checksum-valid executable that cannot start unless the user separately installs the Visual C++ Redistributable.
Target-specific crt-static flags make the Windows artifact self-contained without changing the macOS build. The new CI job exercises the release build and inspects its import table to prevent regression.
Validation