Remove WFE account cache - #8953
Open
aarongable wants to merge 2 commits into
Open
Conversation
aarongable
force-pushed
the
rm-account-cache
branch
from
August 17, 2026 23:17
2fcde5a to
ae6937b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the code implementing the WFE's in-memory account cache. This cache was introduced when our primary bottleneck and source of reliability issues was database reads. We have since improved database performance in a variety of ways, and this minor reduction in read volume is no longer necessary. At the same time, the account cache causes numerous issues: it does not have proper cache invalidation when accounts change state, and it is not shared across multiple WFE instances, so it frequently leads to stale reads which can cause security and correctness issues.
This uncovered a long-standing bug in the integration tests, which had accidentally been relying upon the WFE account cache to authorize two consecutive key rollover requests both signed by the same original key.
Fixes #6144
Fixes #8795
Closes #6744
Closes #8132
Closes #8852
Closes #8796
The corresponding production config changes were made in IN-12897.