trees/issuancelog: Add a shared log identity configuration - #8950
trees/issuancelog: Add a shared log identity configuration#8950beautifulentropy wants to merge 1 commit into
Conversation
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
b01ef71 to
366942a
Compare
| // they configure themselves with from it. | ||
| // | ||
| // https://ietf-plants-wg.github.io/merkle-tree-certs/draft-ietf-plants-merkle-tree-certs.html#name-issuance-logs | ||
| type ID struct { |
There was a problem hiding this comment.
Because this is a config struct, I have a preference for not also using it as a long-lived object, and instead having a separate ID object whose fields are unexported so it is immutable once loaded from the config.
But I also recognize that's significantly more boilerplate in this file, for a layer of abstraction that's probably not strictly necessary yet, so consider this optional feedback.
| mirrorID = "32473.9" | ||
| ) | ||
|
|
||
| var testLogID = issuancelog.ID{CAID: "44947.4.1", LogNumber: 44} |
There was a problem hiding this comment.
nit: we should stop using 44 as our test log number, since Chrome is going to limit us to log numbers 0 through 4 and we'll want to enforce that invariant somewhere.
2 participants
Consolidate the configuration of the CAID and LogNumer into a single struct used by both the MTCA and MTPublisher. Also use the newer CA ID rather than MTCA ID.
Closes #8952