Add lint for CCADB Section 6.3 - #8948
Merged
Merged
Conversation
aarongable
force-pushed
the
ccadb-lints
branch
from
August 14, 2026 23:25
5292148 to
527512c
Compare
aarongable
marked this pull request as ready for review
August 14, 2026 23:34
ezekiel
previously approved these changes
Aug 15, 2026
beautifulentropy
previously approved these changes
Aug 17, 2026
aarongable
dismissed stale reviews from beautifulentropy and ezekiel
via
August 17, 2026 19:30
9b47510
aarongable
force-pushed
the
ccadb-lints
branch
from
August 17, 2026 19:30
1c15479 to
9b47510
Compare
ezekiel
approved these changes
Aug 17, 2026
beautifulentropy
self-requested a review
August 17, 2026 19:39
beautifulentropy
approved these changes
Aug 17, 2026
|
Shouldn't this https://github.com/letsencrypt/boulder/pull/8948/changes#diff-6f0e0e8a03742a85f91c958787b25547b7b66c0a2264914943be3589a1d517a0R59 be |
Contributor
Author
|
You're absolutely correct, thank you for catching that. Off-by-one errors continue to be the Nth hard problem in computer science. Addressed in #8954. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.