tiles: add Frontier to read/write tiles#8896
Open
jsha wants to merge 8 commits into
Open
Conversation
Frontier is loaded at MTCA startup, tracks appended entries and hash tiles, and writes them to storage. Implementation is written by me. The unittest in tiles_test.go was written by Claude and reviewed and lightly edited by me (including rewriting the comments in my own words).
Contributor
Author
|
FYI to reviewers: I was going to implement RootHash in another branch, but it wound up being quick enough I decided to include it in this one. Also, in implementing RootHash it became clear I should switch up the design to allow empty tiles on the frontier and forbid full ones (instead of the other way around). So I did that refactoring and everything got a little bit nicer. |
ezekiel
previously approved these changes
Jul 23, 2026
ezekiel
left a comment
ezekiel
left a comment
Member
There was a problem hiding this comment.
It is cool to see this pull together the entry Bundles and factored-out S3 code to get to the point of a really well-structured and readable tiles package.
Just two tiny comments to consider from me.
ezekiel
requested review from
a team and
aarongable
and removed request for
a team
July 23, 2026 00:07
aarongable
reviewed
Jul 23, 2026
Contributor
Author
|
Pushed responses to most; will think about where to put |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontier is loaded at MTCA startup, tracks appended entries and hash tiles, and writes them to storage.
Implementation is written by me. The unittest in tiles_test.go was written by Claude and reviewed and lightly edited by me (including rewriting the comments in my own words).
Move subtree's
mth()function out from the unittest and export it, since it's needed to calculate a hash to append to a parent tile once its child tile becomes full.Fixes #8894