Add x.com URL support and update Twitter provider endpoint#136
Open
philltran wants to merge 1 commit into
Open
Add x.com URL support and update Twitter provider endpoint#136philltran wants to merge 1 commit into
philltran wants to merge 1 commit into
Conversation
- Extend patterns to match both twitter.com and x.com post URLs - Normalize x.com URLs to twitter.com before proxying (publish.x.com/oembed is unreliable for x.com-domain input; workaround used by WordPress, Umbraco, Ghost, and Rocket.Chat) - Update oEmbed endpoint to canonical https://publish.x.com/oembed - Rename provider to "X (formerly Twitter)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitter rebranded to X and the primary domain for post URLs is now
x.com.The existing provider only matched
twitter.comURLs and proxied to the legacypublish.twitter.comendpoint, sox.com/...post URLs returned no embed.Changes (
lib/Noembed/Provider/Twitter.pm)twitter.comandx.compost URLs(including
www.,mobile., and#!/hash-bang variants).x.comURLs are rewritten totwitter.combeforecalling the endpoint.
publish.x.com/oembeddoes not reliably handlex.com-domain input — this is a documented platform bug with confirmedworkarounds in WordPress core, Umbraco, Ghost, and Rocket.Chat.
https://publish.x.com/oembedper X developer documentation (https://docs.x.com/x-for-websites/oembed-api).
X (formerly Twitter).Testing