Skip to content

fix: use file relative paths as keys in collab server - #163

Closed
robsimmons wants to merge 1 commit into
collab-remove-unused-cleanupfrom
collab-relative-path
Closed

robsimmons wants to merge 1 commit into
collab-remove-unused-cleanupfrom
collab-relative-path

Conversation

@robsimmons

Copy link
Copy Markdown
Collaborator

Tidying in expectation of keeping the collab server's database around for longer: because a project's name could in theory change from my-project-a to my-project-b, it won't do to store files in the collab server's database as /home/my-project-a/Foo/Bar.lean, and so we store them as Foo/Bar.lean instead.

@robsimmons
robsimmons added this pull request to stack #164 September 30, 2026 16:13
@Vtec234

Vtec234 commented Sep 30, 2026

Copy link
Copy Markdown
Member

The general direction makes sense, but we should change the way document names are computed in the client instead. Since #160, collab-server doesn't even know projectDir so will not be able to relativize.

@robsimmons robsimmons closed this Sep 30, 2026
@robsimmons

Copy link
Copy Markdown
Collaborator Author

@Vtec234 was correct, #166 is a much simpler fix

@robsimmons
robsimmons deleted the collab-relative-path branch October 1, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants