Skip to content

chore: remove unused cleanup code - #162

Closed
robsimmons wants to merge 1 commit into
mainfrom
collab-remove-unused-cleanup
Closed

robsimmons wants to merge 1 commit into
mainfrom
collab-remove-unused-cleanup

Conversation

@robsimmons

@robsimmons robsimmons commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

This code wasn't running anyway: bwrap's --die-with-parent option (plus --unshare-pid) means that the collab server got SIGKILLed.

(Additionally, this may not have been doing what we expected even if it had run, because it was only persisting documents that someone had open in their vscode editor: but we terminated collaboration servers after terminating vscode editor sessions, so from the collaboration server's perspective, there were no vscode sessions with tabs open.)

This code wasn't running anyway: bwrap's --die-with-parent option (plus --unshare-pid) means that the collab server got SIGKILLed.
@robsimmons
robsimmons added this pull request to stack #164 September 30, 2026 16:13
@Vtec234

Vtec234 commented Sep 30, 2026

Copy link
Copy Markdown
Member

I don't think this is the right change; the SIGKILL issue (#62) should be fixed, and we should be sending SIGTERM. We do want to stop saving documents to disk - I made that change in #160 - but we should keep server.destroy(); db.close() to persist collab.db.

@robsimmons robsimmons closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants