Repository navigation
Conversation
Contributor
Author
|
No option to allow maintainers to edit pull requests @chenson2018 |
Collaborator
|
!radar |
|
Benchmark results for a9b4873 against 056cf93 are in. There are significant results. @chenson2018
Large changes (1🟥) 1 hidden |
Contributor
Author
|
!radar |
|
Benchmark results for 4128bf4 against e5ed905 are in. No significant results found. @lengyijun
Medium changes (1🟥)
|
chenson2018
reviewed
Aug 9, 2026
Contributor
Author
|
When formalizing "2 vars are not enough", I have proved dozens of theorems related to this file |
lengyijun
force-pushed
the
multiapp
branch
2 times, most recently
from
August 9, 2026 14:09
01b9a56 to
2e72322
Compare
lengyijun
marked this pull request as draft
August 10, 2026 00:40
lengyijun
force-pushed
the
multiapp
branch
6 times, most recently
from
September 2, 2026 05:25
7affea2 to
572a073
Compare
lengyijun
changed the title
lengyijun
changed the title
lengyijun
force-pushed
the
multiapp
branch
2 times, most recently
from
September 2, 2026 05:28
e182ced to
c5a5623
Compare
lengyijun
marked this pull request as ready for review
September 2, 2026 05:30
lengyijun
requested review from
arademaker,
kim-em and
sorrachai
as code owners
September 16, 2026 05:07
lengyijun
force-pushed
the
multiapp
branch
2 times, most recently
from
September 21, 2026 23:47
5d92054 to
312307a
Compare
lengyijun
force-pushed
the
multiapp
branch
3 times, most recently
from
September 28, 2026 00:14
57712e5 to
5d6f38c
Compare
lengyijun
force-pushed
the
multiapp
branch
2 times, most recently
from
October 5, 2026 00:29
be5a94a to
1960afa
Compare
SamuelSchlesinger
requested changes
Oct 10, 2026
| | nil => grind [cases Xi] | ||
| | append_singleton Ps P ih => | ||
| rw [multiApp_tail] at h_red | ||
| unfold multiApp at h_red |
Collaborator
There was a problem hiding this comment.
Could we keep multiApp_tail instead of unfolding everywhere?
Contributor
Author
There was a problem hiding this comment.
I now use simp only [List.foldl_concat], so there’s no need to unfold multiApp anymore.
lengyijun
force-pushed
the
multiapp
branch
3 times, most recently
from
October 14, 2026 04:56
e49ea4a to
a1ee076
Compare
Replace the recursive multiApp definition with List.foldl app Remove the now-unnecessary multiApp_tail lemma and adapt proofs to List.foldl_concat Make semanticMap_saturated use explicit grind only lemmas for the new multiApp representation New theorems : multiapp_openRec and multiapp_fv
Rename `listFullBeta_cons_r/l` to `listFullBeta_concat_r/l` to reflect their general concatenation behavior. Add specialized `cons` lemmas for reducing the head term or the tail list.
Add `step_multiApp_l_union` to lift a single `(Xi R1 ⊔ Xi R2)` reduction through a multi-application. Add `steps_multiApp_l_union` for the corresponding reflexive-transitive closure. Use the new single-step lemma to simplify the proof of the multi-step result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the recursive
multiAppdefinition withList.foldl appRemove the now-unnecessary
multiApp_taillemma and adapt proofs toList.foldl_concatgrind [multiApp_tail]=>grindMake
semanticMap_saturateduse explicitgrind only: performance considerationNew theorems :
multiapp_openRecmultiapp_fvstep_multiApp_l_unionsteps_multiApp_l_unionRename
listFullBeta_cons_r/ltolistFullBeta_append_r/lto reflect their general concatenationAdd specialized
conslemmas for reducing the head term or the tail list.Fix #784