chore(js-client): upgrade to TypeScript 6#93
Draft
claude[bot] wants to merge 1 commit into
Draft
Conversation
Bump typescript ^5.9.3 -> ^6.0.3 with a proper tsconfig migration so the workspace compiles cleanly under TS 6 without ignoreDeprecations: - Remove the deprecated `baseUrl` and rebase the `@leancodepl/pipe` path map to a relative specifier (TS resolves `paths` without `baseUrl` since 4.1). - Migrate `moduleResolution` from the deprecated `"node"` to `"bundler"` (the pipe lib is bundled via rollup/swc), matching js_corelibrary's org-preferred setting. `module` stays `ESNext`. Verified on Node 24.18: nx lint / build / test are green (the live integration test only 403s on the sandbox egress block) and tsc reports no TS5101 deprecation errors, with no ignoreDeprecations escape hatch. Stacked on chore/js-client-npm-dependencies-bump (#92). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ET2dL5CiUkuFR1ZGiUrUH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Łukasz Komoszyński · Slack thread
Upgrades the
js-client/package to TypeScript 6.0.3, done as a real tsconfig migration rather than by silencing the TS 6 deprecation errors.Why this is a separate PR
#92 briefly carried the
typescript 5.9.3 → 6.0.3bump using"ignoreDeprecations": "6.0"intsconfig.base.json. That only mutes the errors and defers the real work. #92 has been reverted back to TypeScript5.9.3(droppingignoreDeprecations), and the upgrade lives here instead, migrated properly.What changed
typescript^5.9.3→^6.0.3.typescript-eslint@8.64.0already supports it (peertypescript <6.1.0).baseUrl. TS 6 turns the deprecatedbaseUrlinto a hard build error (TS5101). It was only present to anchor the@leancodepl/pipepath mapping; TypeScript has resolvedpathsrelative to the config file withoutbaseUrlsince 4.1, so the mapping is now a relative specifier:baseUrl-relative bare specifiers, so nothing else needed rewriting.moduleResolution"node"→"bundler". TS 6 also hard-errors on the deprecated"node"(akanode10) resolver. The pipe library is bundled through@nx/rollup+ swc, so"bundler"is the correct fit — and it matches js_corelibrary's org-preferredtsconfig.base.json.modulestaysESNext(compatible withbundler).ignoreDeprecations. The escape hatch is intentionally absent;tscreports zeroTS5101deprecation errors under the migrated config.Test status
Verified on Node 24.18 (
.nvmrc):nx lint pipeandnx build pipeare green, andtsc -p packages/pipe/tsconfig.lib.json --noEmitreports no errors. Tests pass except the single live-backend integration test (packages/pipe/__tests__/pipe.spec.ts), which fails only because the sandbox blocksapi.exampleapp.test.lncd.plby egress policy (403) — the same environmental caveat as #92, not a code failure. It is expected to pass in CI.Generated by Claude Code