Conversation
* Chinese Wade-Giles to Pinyin * Devanagari (generic) * Malayalam * Tibetan
RandyBarry
left a comment
RandyBarry
left a comment
There was a problem hiding this comment.
Everything looks fine. NOTE: my testing of Osage reveals that the _ignore_base rule for Roman numeral “C” is preventing the conversion of this Latin letter to the Osage equivalent. Single uppercase Latin letters C D I L M N V must be excluded in the _ignore_base logic for Roman numerals.
|
@RandyBarry if you approve the PR I can merge it. Thanks. |
thisismattmiller
left a comment
thisismattmiller
left a comment
There was a problem hiding this comment.
Everything looks fine. NOTE: my testing of Osage reveals that the _ignore_base rule for Roman numeral “C” is preventing the conversion of this Latin letter to the Osage equivalent. Single uppercase Latin letters C D I L M N V must be excluded in the _ignore_base logic for Roman numerals.
|
I think I caught an edge case for the single C Roman digit. I will handle that in a separate PR. Merging for now. |
3 participants
No description provided.