feat: commonizes several FDv2 related types in Internal#141
Merged
tanderson-ld merged 6 commits intoFeb 26, 2026
Conversation
…ta/SDK-1817/commonizing-fdv2-source-types-internal
tanderson-ld
changed the title
tanderson-ld
changed the title
Base automatically changed from
ta/SDK-1817/commonizing-fdv2-source-types-common
to
main
February 26, 2026 21:07
tanderson-ld
changed the title
tanderson-ld
commented
Feb 26, 2026
kinyoklion
approved these changes
Feb 26, 2026
tanderson-ld
deleted the
ta/SDK-1817/commonizing-fdv2-source-types-internal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Selector into Common and updates a couple imports to use it.
Note
Medium Risk
Upgrades
launchdarkly-java-sdk-commonand relocates the FDv2Selectortype, which can cause compile-time breaks for any code still importing the internal package and may subtly change semantics via the common implementation.Overview
FDv2 now uses the shared
com.launchdarkly.sdk.fdv2.Selectortype: internal FDv2 sources (FDv2ChangeSet,FDv2ProtocolHandler) update imports accordingly and the oldinternal.fdv2.sources.Selectorclass is removed.Also bumps the
launchdarkly-java-sdk-commondependency from2.1.2to2.4.0to supply the commonized FDv2 types.Written by Cursor Bugbot for commit f478282. This will update automatically on new commits. Configure here.
BEGIN_COMMIT_OVERRIDE
feat: commonizes several FDv2 related types
END_COMMIT_OVERRIDE