feat: add internal BigSegmentsBuilder + config struct#541
Open
beekld wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal-only plumbing for Big Segments configuration: a private
BigSegmentsBuilder(undersrc/config/builders/) that produces a publicbuilt::BigSegmentsConfig. NoConfigBuildermethod yet, so this isn't reachable from customer code.Test plan
BigSegmentsBuilderTestcases passNote
Low Risk
New internal config types and builder only; no client wiring or evaluation behavior changes yet, with behavior locked by unit tests.
Overview
Adds internal Big Segments configuration plumbing: a public
built::BigSegmentsConfigvalue type and a privateBigSegmentsBuilderundersrc/config/builders/that resolves store pointer, LRU cache size/TTL, metadata poll interval, and stale-after threshold.Build()applies spec defaults (e.g. 1000 cache entries, 5s cache/poll, 2min stale), coerces zero/negative durations back to defaults, and clampsstatus_poll_intervaltostale_afterwhen poll would be slower than staleness detection. A null store is allowed for “not configured.” CMake picks up the new built header glob andbig_segments_builder.cpp; nine unit tests cover defaults, setters, coercion, clamping, and repeatability. There is still noConfigBuilderhook—customer-facing wiring is not in this diff.Reviewed by Cursor Bugbot for commit 915ddb1. Bugbot is set up for automated code reviews on this repo. Configure here.