Improve OKR shortcuts#1487
Merged
Merged
Conversation
Add three new OKR shortcuts for managing objectives and key results: - +batch-create: Bulk create objectives with key results, with automatic rollback on failure - +reorder: Adjust position of objectives or key results within a cycle/objective - +weight: Adjust weights of objectives or key results with automatic normalization using fixed-point arithmetic to avoid float precision issues Key implementation details: - API paths use underscore separators (/objectives_position, /objectives_weight) - Weight normalization uses json.Number for precise JSON serialization - Items are sorted by position before API calls to match backend requirements - Full unit test coverage and dry-run/live E2E tests - Skill documentation with usage examples and parameter descriptions Change-Id: I92b658e0cc42ffa8cbdaec2ec628a079bcfc38f5
Change-Id: I862190b066fb98276ef28d5d6d47063a9a3ef3ae
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds four new OKR CLI shortcut commands ( ChangesOKR Shortcut Commands
Sequence Diagram(s)sequenceDiagram
participant User as CLI User
participant BatchCreate as +batch-create Execute
participant API as Lark OKR v2 API
participant Rollback as rollback()
User->>BatchCreate: --cycle-id --input JSON
loop for each objective
BatchCreate->>API: POST /okr/v2/objectives
API-->>BatchCreate: objective_id
loop for each key result
BatchCreate->>API: POST /okr/v2/objectives/{id}/key_results
alt KR creation fails
API-->>BatchCreate: error
BatchCreate->>Rollback: delete created objectives (reverse)
Rollback->>API: DELETE /okr/v2/objectives/{id}
Rollback-->>BatchCreate: deletion results
BatchCreate-->>User: rollback error + residual IDs
else success
API-->>BatchCreate: key_result_id
end
end
end
BatchCreate-->>User: ok=true, data.created[{objective_id, krs}]
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change-Id: I3f27a01cdae2122f26e48ee2acb7f334f2bab7d2
syh-cpdsss
force-pushed
the
feat/okr-shortcuts
branch
from
0af7c85 to
6e2b7fc
Compare
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@b896fd8b82445f89571f896d3225f382680fc9a5🧩 Skill updatenpx skills add larksuite/cli#feat/okr-shortcuts -y -g |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
+ Coverage 73.72% 73.78% +0.06%
==========================================
Files 781 785 +4
Lines 74217 75042 +825
==========================================
+ Hits 54717 55372 +655
- Misses 15437 15554 +117
- Partials 4063 4116 +53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 17
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shortcuts/okr/okr_indicator_update_test.go (1)
43-363:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDry-run behavior is missing dedicated test coverage.
+indicator-updatehas a two-step dry-run plan (GET indicators + PATCH template), but this file has no--dry-runassertion for endpoint/body rendering. Add one to cover request structure/output for this behavior path.As per coding guidelines, every behavior change needs a test alongside the change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/okr/okr_indicator_update_test.go` around lines 43 - 363, Add test coverage for the dry-run behavior of the indicator-update shortcut. Create test functions that verify the --dry-run flag behavior by testing both the GET indicators request and the PATCH template rendering without actually executing the API calls. These tests should assert that the endpoint calls are prepared correctly and that the output shows the request structure (URL, method, body) that would be executed, similar to the existing validation and execution tests (TestIndicatorUpdateValidate_Valid, TestIndicatorUpdateExecute_Objectives_Success, etc.). Include separate test cases for both objective and key-result levels to ensure the dry-run behavior works correctly for different endpoint paths.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/okr/okr_batch_create_test.go`:
- Around line 457-460: The rollback error-path assertion currently only checks
error message substrings for "rolling back" or "rollback". Strengthen this test
by also asserting the error's typed metadata using errs.ProblemOf(err) to verify
the category and subtype fields match expected values, and assert cause
preservation using errors.Unwrap() or errors.Is() to ensure the underlying error
is properly wrapped and propagated. Apply this same pattern of typed assertions
plus cause checks instead of message substrings at all affected error validation
locations.
In `@shortcuts/okr/okr_batch_create.go`:
- Around line 348-364: The loop that populates residualIDs (lines 348-352)
unconditionally appends all created objectives regardless of whether rollback
succeeded or failed. Modify this loop to only collect objective IDs into
residualIDs when rollback actually failed or was not attempted. This typically
means adding a conditional check before the loop to only execute it when
len(rollbackErrs) > 0 (indicating rollback had failures), so users are not
instructed to manually clean up objectives that were already successfully
deleted during a completed rollback.
- Around line 345-367: The buildRollbackError function currently downgrades
typed errors by always returning errs.NewInternalError with SubtypeUnknown,
regardless of the actual error type from originalErr. Instead of creating a new
InternalError, extract the error type and subtype from originalErr and preserve
it when constructing the return error. If originalErr is already a properly
typed error, use its type information in the error creation rather than
overriding it with SubtypeUnknown. This ensures that API/network failures
maintain their original classification rather than being reclassified as generic
internal errors.
In `@shortcuts/okr/okr_indicator_update_test.go`:
- Around line 279-300: The test functions
TestIndicatorUpdateExecute_FetchAPIError (at lines 279-300) and the patch
failure test (at lines 302-337) currently only check for non-nil errors without
asserting typed problem metadata. Replace the weak `if err == nil` checks with
typed assertions using errs.ProblemOf(err) to verify the error category and
subtype, and additionally assert the presence of unwrap or cause information to
properly lock in the error contract behavior as required by the coding
guidelines.
In `@shortcuts/okr/okr_indicator_update.go`:
- Around line 71-73: The flags "level", "id", and "value" are using Required:
true which causes missing-flag failures to be handled as plain errors by Cobra
instead of following the typed error contract. Remove the Required: true
attribute from all three flag definitions in the diff section, then add
corresponding validation logic in the Validate method that checks if these flags
are provided and returns typed errs.NewValidationError with WithParam metadata
for each missing required flag instead of relying on Cobra's error handling.
- Around line 19-22: The validation error returned when strconv.ParseFloat fails
does not preserve the underlying parse error, which breaks error cause chain
diagnostics. Split the condition checking so that parse errors (when err != nil
from ParseFloat) are handled separately from range/NaN/Inf validation checks.
For the parse error case, attach the actual error using .WithCause(err) to
preserve the error chain. The range/NaN/Inf checks can remain combined or
separate as appropriate, but only the parse failure path needs the cause
attachment.
In `@shortcuts/okr/okr_reorder_test.go`:
- Around line 142-165: The test TestReorderValidate_InvalidOpsJSON currently
verifies the error type and param but does not assert the category and subtype
metadata via errs.ProblemOf, and does not verify that the invalid-JSON cause is
preserved in the error chain. Strengthen the assertion by capturing the problem
returned from errs.ProblemOf(err) and assert its category and subtype fields
match expected values. Additionally, assert that the error wraps the underlying
JSON parsing error by checking the error's Unwrap() method or cause chain. Apply
the same strengthened assertions to the similar tests at lines 192-246 and
504-546, ensuring all error-path tests verify typed metadata and cause
preservation rather than relying solely on message substrings.
In `@shortcuts/okr/okr_reorder.go`:
- Around line 68-73: The pagination loop uses a fixed time.Sleep() call that
ignores context cancellation, preventing users from cleanly canceling long
pagination operations. Replace the time.Sleep() with a context-aware sleep
mechanism using a select statement that checks both ctx.Done() and a timer
channel. This allows the sleep to be interrupted immediately when the context is
canceled, enabling graceful cancellation of the pagination flow. Apply this fix
to all occurrences of the fixed sleep pattern in the pagination loops.
- Around line 245-249: Remove the Required: true constraint from the level,
cycle-id, and ops flags in the reorder command configuration, as this causes
Cobra to fail with non-typed errors before the Validate function executes.
Instead, move the validation logic into the Validate function for the reorder
command to check that these three flags are present and return properly typed
errs.* errors when they are missing, ensuring command-facing failures use typed
validation errors as per coding guidelines.
In `@shortcuts/okr/okr_weight_test.go`:
- Around line 83-93: The error-path tests are not asserting the full typed error
contract as required by coding guidelines. While the tests check that
errs.ProblemOf returns successfully and verify the Param field, they do not
assert the actual category and subtype values returned by errs.ProblemOf, and
wrapped error paths do not verify cause preservation. For all affected locations
(in the ranges 83-93, 122-132, 161-171, 186-196, 211-221, 239-249, 264-274,
292-302, 320-330, and 556-566 in okr_weight_test.go), enhance the error
assertions to capture and validate the Problem object returned by
errs.ProblemOf, then assert both the category and subtype fields match the
expected values. For any tests that involve error wrapping, add additional
assertions to verify that the cause error is correctly preserved in the error
chain. This ensures all error-path tests comprehensively validate the full typed
error contract rather than only checking Param.
- Around line 33-40: The weightTestConfig helper function is missing environment
isolation for test configuration state. Add a call to
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir()) at the beginning of the
weightTestConfig function to ensure each test gets an isolated temporary
configuration directory, following the coding guidelines for test config
isolation.
In `@shortcuts/okr/okr_weight.go`:
- Around line 483-487: The weightEntry["weight"] value is a json.Number type,
but the format string %.3f in the fprintf call expects a float64. Convert the
json.Number to float64 before formatting it in the fprintf statement at line
486. Use the appropriate method to parse the json.Number value to a float64 and
handle any conversion errors that may occur.
In `@skills/lark-okr/references/lark-okr-indicator-update.md`:
- Line 42: The CLI command notation on this line is inconsistent with earlier
examples in the document. Line 42 uses dot notation (objective.indicators.list
and key_result.indicators.list) while earlier examples use space-separated
notation (objective.indicators list and key_result.indicators list). Update line
42 to use the space-separated format consistently with the earlier examples to
prevent confusion and copy/paste errors for users.
In `@skills/lark-okr/references/lark-okr-reorder.md`:
- Around line 46-47: The documentation for the lark-okr-reorder command contains
inaccuracies. Review the actual implementation to clarify the requirements for
the --cycle-id parameter and its conditional necessity. Update the parameter
description for --cycle-id at lines 46-47 to accurately reflect when it is
required versus optional. Additionally, update the sample response section to
match the actual implementation output fields, replacing the incorrect fields
(cycle_id, new_order) with the actual output fields (level, total, ordered).
Apply these same corrections to all affected locations including the areas
around lines 61-75 to ensure the documentation is consistent throughout.
In `@skills/lark-okr/references/lark-okr-weight.md`:
- Around line 71-83: The JSON response example in the lark-okr-weight.md
documentation includes a `cycle_id` field within the `data` object, but the
actual Execute implementation does not return this field. Remove the `cycle_id`
field from the example response block (which currently shows `"cycle_id":
"7000000000000000001"`) so that the documented output schema matches the actual
CLI implementation that only returns `level`, `total`, and `weights` fields.
- Around line 20-29: The section header "调整 KR 权重（全部指定，和为 1）" indicates weights
should sum to 1.0, but the example shows weights of 0.5 and 0.3 which sum to
only 0.8. Fix this inconsistency by either adjusting the weight values in the
example to sum to exactly 1.0 (for instance, change the second weight from 0.3
to 0.5 to make the total 1.0), or change the section header from "全部指定，和为 1" to
"部分指定" to accurately reflect that the example is showing partial weight
specification. Choose the option that matches the intent of the documentation.
In `@tests/cli_e2e/okr/okr_shortcuts_test.go`:
- Around line 289-294: The cleanup registration for the `cleanupLiveTest()`
function must be moved to execute immediately after resource creation by
`createTestObjectives()`, before any assertions that could fail. Currently, if
`createTestObjectives()` internally fails on a `require.*` check after creating
resources (as noted in Lines 225-229), the test terminates before cleanup is
ever registered. To fix this across all affected sites (lines 289-294, 338-345,
and 399-406), either move all assertions out of `createTestObjectives()` to
happen after cleanup registration, or refactor `createTestObjectives()` to
return an error value and always call `t.Cleanup()` immediately after the
function returns, before performing any assertions on the created objects.
---
Outside diff comments:
In `@shortcuts/okr/okr_indicator_update_test.go`:
- Around line 43-363: Add test coverage for the dry-run behavior of the
indicator-update shortcut. Create test functions that verify the --dry-run flag
behavior by testing both the GET indicators request and the PATCH template
rendering without actually executing the API calls. These tests should assert
that the endpoint calls are prepared correctly and that the output shows the
request structure (URL, method, body) that would be executed, similar to the
existing validation and execution tests (TestIndicatorUpdateValidate_Valid,
TestIndicatorUpdateExecute_Objectives_Success, etc.). Include separate test
cases for both objective and key-result levels to ensure the dry-run behavior
works correctly for different endpoint paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a6b2c597-ef81-41c1-b4f7-5f0a0db27112
📒 Files selected for processing (15)
shortcuts/okr/okr_batch_create.goshortcuts/okr/okr_batch_create_test.goshortcuts/okr/okr_indicator_update.goshortcuts/okr/okr_indicator_update_test.goshortcuts/okr/okr_reorder.goshortcuts/okr/okr_reorder_test.goshortcuts/okr/okr_weight.goshortcuts/okr/okr_weight_test.goshortcuts/okr/shortcuts.goskills/lark-okr/SKILL.mdskills/lark-okr/references/lark-okr-batch-create.mdskills/lark-okr/references/lark-okr-indicator-update.mdskills/lark-okr/references/lark-okr-reorder.mdskills/lark-okr/references/lark-okr-weight.mdtests/cli_e2e/okr/okr_shortcuts_test.go
Change-Id: Id9fab84e06f0d67e9f79c1fb9946b6b633200592
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shortcuts/okr/okr_weight_test.go (1)
507-520:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winStrengthen execute success checks with per-ID weight assertions.
Current assertions can pass even if allocation is wrong but still sums to
1.0. Add assertions for expected IDs and at least the explicitly specified weight values (e.g., objectiveid=1should remain0.7, key-resultid=kr1should remain0.5), plus expected list length.💡 Minimal assertion hardening
@@ - weights, _ := data["weights"].([]interface{}) + weights, _ := data["weights"].([]interface{}) if len(weights) != 2 { t.Fatalf("expected 2 items in weights list, got %d", len(weights)) } + byID := map[string]float64{} + for _, w := range weights { + wm, _ := w.(map[string]interface{}) + id, _ := wm["id"].(string) + byID[id] = getWeightFloat(wm["weight"]) + } + if math.Abs(byID["1"]-0.7) > 1e-9 { + t.Fatalf("expected id=1 weight=0.7, got %.10f", byID["1"]) + } @@ - weights, _ := data["weights"].([]interface{}) + weights, _ := data["weights"].([]interface{}) + if len(weights) != 3 { + t.Fatalf("expected 3 items in weights list, got %d", len(weights)) + } + byID := map[string]float64{} + for _, w := range weights { + wm, _ := w.(map[string]interface{}) + id, _ := wm["id"].(string) + byID[id] = getWeightFloat(wm["weight"]) + } + if math.Abs(byID["kr1"]-0.5) > 1e-9 { + t.Fatalf("expected kr1 weight=0.5, got %.10f", byID["kr1"]) + }Also applies to: 577-588
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/okr/okr_weight_test.go` around lines 507 - 520, The current test assertions in the weight verification blocks are insufficient as they only validate that two items exist and sum to 1.0, but do not verify that each specific item has the correct weight assigned to it. Add assertions after the length check to verify the expected IDs and their corresponding weight values are present in the weights list. For each weight element retrieved from the weights list, extract both the ID (using a key like "id") and the weight value (already being extracted via getWeightFloat), then assert that objective id=1 has weight 0.7 and key-result id=kr1 has weight 0.5. Apply this hardening to both affected test sections (around lines 507-520 and 577-588) to ensure allocation correctness beyond just sum validation.
🧹 Nitpick comments (2)
shortcuts/okr/okr_reorder_test.go (2)
166-168: 💤 Low valueTautological
errors.Ischecks aftererrors.Assucceeds.After
errors.As(err, &validationErr)succeeds and assignsvalidationErr, the subsequenterrors.Is(err, validationErr)is always true by definition—iferrcontainsvalidationErr(found byAs), thenIswill find it too. These checks don't add value and can be removed.Also applies to: 222-224, 256-258, 568-570
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/okr/okr_reorder_test.go` around lines 166 - 168, Remove the redundant errors.Is checks that appear after successful errors.As calls in the test file, as they are tautological—once errors.As succeeds in finding and assigning validationErr, errors.Is will always return true by definition. Delete the if statements checking errors.Is at lines 166-168, 222-224, 256-258, and 568-570 since they do not add value to the test assertions.
51-63: 💤 Low valueMissing-flag tests rely on string matching instead of typed errors.
These tests check for flag names in error messages via
strings.Contains, which works but doesn't verify the error is typed. Since the implementation now uses typederrs.NewValidationErrorfor these cases (per the flag validation changes), consider updating these tests to assert typed metadata.However, if these tests are intentionally covering the case where Cobra's enum validation fails before
Validateruns (for--level), the current approach is acceptable since Cobra errors aren't typed.Also applies to: 90-102, 129-141
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/okr/okr_reorder_test.go` around lines 51 - 63, The test `TestReorderValidate_MissingLevel` (and similar tests referenced at lines 90-102 and 129-141) currently rely on `strings.Contains` to verify error messages, which doesn't validate the error type. Since the implementation now uses typed `errs.NewValidationError` for validation cases, determine whether this specific test is verifying Cobra's built-in enum validation (which occurs before the custom Validate method and is not typed) or custom validation (which should use the typed error). If the test is checking custom validation errors created with `errs.NewValidationError`, update the assertion to verify the typed error metadata instead of string matching the error message. If this test is intentionally covering Cobra's pre-validation behavior, the current string matching approach can remain acceptable and this can be documented.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@shortcuts/okr/okr_weight_test.go`:
- Around line 507-520: The current test assertions in the weight verification
blocks are insufficient as they only validate that two items exist and sum to
1.0, but do not verify that each specific item has the correct weight assigned
to it. Add assertions after the length check to verify the expected IDs and
their corresponding weight values are present in the weights list. For each
weight element retrieved from the weights list, extract both the ID (using a key
like "id") and the weight value (already being extracted via getWeightFloat),
then assert that objective id=1 has weight 0.7 and key-result id=kr1 has weight
0.5. Apply this hardening to both affected test sections (around lines 507-520
and 577-588) to ensure allocation correctness beyond just sum validation.
---
Nitpick comments:
In `@shortcuts/okr/okr_reorder_test.go`:
- Around line 166-168: Remove the redundant errors.Is checks that appear after
successful errors.As calls in the test file, as they are tautological—once
errors.As succeeds in finding and assigning validationErr, errors.Is will always
return true by definition. Delete the if statements checking errors.Is at lines
166-168, 222-224, 256-258, and 568-570 since they do not add value to the test
assertions.
- Around line 51-63: The test `TestReorderValidate_MissingLevel` (and similar
tests referenced at lines 90-102 and 129-141) currently rely on
`strings.Contains` to verify error messages, which doesn't validate the error
type. Since the implementation now uses typed `errs.NewValidationError` for
validation cases, determine whether this specific test is verifying Cobra's
built-in enum validation (which occurs before the custom Validate method and is
not typed) or custom validation (which should use the typed error). If the test
is checking custom validation errors created with `errs.NewValidationError`,
update the assertion to verify the typed error metadata instead of string
matching the error message. If this test is intentionally covering Cobra's
pre-validation behavior, the current string matching approach can remain
acceptable and this can be documented.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0e6aa937-a2d0-4b48-97d3-7a1950348eef
📒 Files selected for processing (12)
shortcuts/okr/okr_batch_create.goshortcuts/okr/okr_batch_create_test.goshortcuts/okr/okr_indicator_update.goshortcuts/okr/okr_indicator_update_test.goshortcuts/okr/okr_reorder.goshortcuts/okr/okr_reorder_test.goshortcuts/okr/okr_weight.goshortcuts/okr/okr_weight_test.goskills/lark-okr/references/lark-okr-indicator-update.mdskills/lark-okr/references/lark-okr-reorder.mdskills/lark-okr/references/lark-okr-weight.mdtests/cli_e2e/okr/okr_shortcuts_test.go
✅ Files skipped from review due to trivial changes (1)
- skills/lark-okr/references/lark-okr-reorder.md
🚧 Files skipped from review as they are similar to previous changes (7)
- skills/lark-okr/references/lark-okr-weight.md
- shortcuts/okr/okr_batch_create.go
- shortcuts/okr/okr_weight.go
- shortcuts/okr/okr_batch_create_test.go
- shortcuts/okr/okr_indicator_update.go
- tests/cli_e2e/okr/okr_shortcuts_test.go
- shortcuts/okr/okr_indicator_update_test.go
Change-Id: I6a5e57dd4b10dc79f8681ec614354fbba82abc04
syh-cpdsss
force-pushed
the
feat/okr-shortcuts
branch
from
9c04e34 to
09a97d8
Compare
Change-Id: I6e2a39269e62e3b504e681110843b2ccc315a527
Change-Id: I81dcdf5f89edd5b5c2277b8391b59dd79cc581aa
zhangzq0
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds four new OKR shortcuts to streamline common OKR management operations:
+batch-create,+reorder,+weight, and+indicator-update, improving success rates and reduce token usage for end-to-end OKR workflows.Changes
+batch-createshortcut (shortcuts/okr/okr_batch_create.go): Atomic batch creation of Objectives and Key Results with automatic rollback on failure. Supports@mentionin content, file/stdin input via@path/@-, and--dry-runfor preview.+reordershortcut (shortcuts/okr/okr_reorder.go): Position-based reordering for both Objectives (cycle-level) and Key Results (objective-level). Accepts partial position changes and automatically constructs the full ordered ID list required by the nativeobjectives_position/key_results_positionAPIs.+weightshortcut (shortcuts/okr/okr_weight.go): Smart weight allocation for Objectives and KRs. Supports partial weight specification with automatic normalization of unspecified items based on original weight proportions, ensuring the total always equals 1.0.+indicator-updateshortcut (shortcuts/okr/okr_indicator_update.go): Simplified indicator current value update. Automatically looks up the indicator ID for a given Objective/KR ID and updates thecurrent_valuefield, eliminating the need for a separate indicator list API call.skills/lark-okr/SKILL.md): Added all four shortcuts to the Shortcuts table with links to detailed reference docs.lark-okr-batch-create.md,lark-okr-reorder.md,lark-okr-weight.md,lark-okr-indicator-update.md) including command examples, parameter tables, input/output formats, and workflow guidance.tests/cli_e2e/okr/okr_shortcuts_test.gowith dry-run and live E2E tests validating the complete shortcut request/response flow.shortcuts/okr/shortcuts.go.Test Plan
Related Issues
Summary by CodeRabbit
Release Notes
okr +batch-createto batch-create OKR objectives and key results from JSON, with validation, optional mentions, dry-run planning, and rollback on failures.okr +indicator-updateto update an indicator’scurrent_valueat objective or key-result level, including dry-run support.okr +reorderto reorder objectives or key results via--ops, with dry-run previews.okr +weightto set objective/key-result weights with validation and normalization to a total of 1.0, plus dry-run.