Ignore a fit's run log wherever it was launched from - #722
Merged
Merged
Conversation
.gitignore covered bnf_*.log under examples/ and one level under benchmarks/, which is where a stray run log had been noticed, but not the repository root. A fit launched from the root leaves bnf_<timestamp>.log there and it shows up as an untracked file, as two did while measuring #696. One rule for every directory replaces the two location-specific ones rather than adding a third. These are runtime logs: none has ever been committed, and nothing currently tracked matches the broader pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignorecoveredbnf_*.logunderexamples/and one level underbenchmarks/— the two places a stray run log had been noticed — but not the repository root. A fit launched from the root leavesbnf_<timestamp>.logthere and it shows up as an untracked file; two did while measuring #696.One rule for every directory replaces the two location-specific ones, rather than adding a third that would be followed by a fourth. These are runtime logs, none has ever been committed, and
git ls-files | git check-ignore --stdinis empty against the broader pattern, so nothing tracked is shadowed.Verified that a log at the repository root, under
examples/tutorial/, and underbenchmarks/stochastic_recovery/is ignored.