Conversation
westonpace
requested changes
Sep 18, 2026
westonpace
left a comment
westonpace
left a comment
Contributor
There was a problem hiding this comment.
Various suggestions but overall this looks like a great improvement. I think many of these suggestions were issues present in the previous iteration as well.
| ##### Checkpointing with Multiple DataLoader Workers | ||
|
|
||
| Use `StreamingDataLoader` when you want multi-worker prefetch and exact resumability. It carries a state snapshot | ||
| Python's built-in `torch.utils.data.DataLoader` produces a safe checkpoint when `num_workers = 0`. With `num_workers > 0`, calling `state_dict()` on the often raises `RuntimeError`. In this case, use `StreamingDataLoader` for multi-worker prefetch and exact resumability. It carries a state snapshot |
Contributor
There was a problem hiding this comment.
"calling state_dict() on the often <-- grammar
Also though, does DataLoader have a state_dict function? What is this talking about?
Contributor
Author
There was a problem hiding this comment.
I don't know. Inherited from the previous version
Co-authored-by: Weston Pace <weston.pace@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to data loading documentation, as part of Jason's internship project. Reorganized the "Data Loading" tab of the public-facing documentation, and added new section regarding 2-phase shuffled read. Slack me with questions