Repository navigation
NA500: trigger a TTL pulse on the BNC output - #23
Merged
Merged
Conversation
EGIAmpClient::triggerBncOut(widthUs) puts the NA500's BNC output in manual mode (cmd_SetBncOutMode 1), sets the pulse width (100-1600 us, the range Net Station offers) and fires it with cmd_SetTriggerBncManualOut. Mode and width are sent once per connection, so a trigger normally costs one command round trip. The GUI gets a "BNC Trigger" button (1 ms pulse), enabled while linked to an NA500. AmpServerConnection::sendCommand is now serialized: the UI thread and the impedance scan thread can send commands concurrently. The NA500 mock accepts the BNC-out commands, logs each pulse, and loops it back to its BNC input so it appears in the _DIN stream. Also fixes Unlink in the GUI leaving "Shutdown Amp Server" disabled and the impedance checkbox enabled. Verified on a GES 500 (fw 0.4.9) with BNC out cabled to BNC in: 0 BNC-in events in 10 s without triggers; 30 triggers produced exactly 30 events, each within +/-1 ms of the command. Co-Authored-By: Claude <noreply@anthropic.com>
3 of 4 tasks
GitHub no longer runs the macos-14 image ("The configuration
'macos-14-arm64-us-default' is not supported").
Co-Authored-By: Claude <noreply@anthropic.com>
0 to 5.0 V, about 6.7% (16/15) longer than the set width, measured with a USB-1608FS-Plus at 100 kHz on a GES 500 (fw 0.4.9). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EGIAmpClient::triggerBncOut(widthUs)fires one TTL pulse on the GES 500's BNC output: manual mode (cmd_SetBncOutMode 1), pulse width (100–1600 µs, the range Net Station offers), thencmd_SetTriggerBncManualOut. Mode and width are sent once per connection, so a trigger normally costs one command round trip.--amp-type NA500): accepts the BNC-out commands, logs each pulse, and loops it back to the BNC input so it shows up in the_DINstream.AmpServerConnection::sendCommandis now serialized (UI thread and impedance scan thread can send concurrently).Test plan
🤖 Generated with Claude Code