Repository navigation
fix(middleware): harden redirect URL construction in v4 - #3224
Merged
Merged
Conversation
vishr
force-pushed
the
fix/v4-redirect-host-validation
branch
from
November 12, 2026 06:38
d018055 to
2cf7d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3220 to v4. Closes #3217 for v4.
:or., contains%, or becomes empty after removingwww..OPTIONS *requests.ws/wsstohttp/httpsin redirect targets.www.prefix case-insensitively.HTTPSWWWRedirectkeeps its v4 semantics: plain HTTP requests to hosts that already start withwww.are not redirected. Changing that in a patch release can cause redirect loops whenScheme()cannot detect HTTPS behind a proxy. v5 redirects these requests.Tests are adapted to the v4
echo.Contextinterface.