Repository navigation
fix(desktop): restrict loopback origins to debug builds (MEET-11) - #379
Merged
Merged
Conversation
eliotlim
enabled auto-merge (squash)
October 6, 2026 14:30
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
eliotlim
disabled auto-merge
October 7, 2026 13:37
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release builds trusted http(s)://localhost|127.0.0.1 on ANY port as app origins; with the mic entitlement and wry 0.55.1's media-capture auto-grant, a co-resident local process could capture audio under OpenBook's TCC grant. Sasha finding from the MEET-8 review. Board: MEET-11.
Solution
is_app_origin→ testableis_app_origin_for_build(url, is_debug); loopback arm returnsis_debug. Release trusts only tauri://localhost + tauri.localhost; loopback navigations degrade to OpenExternal. Release provably needs no loopback navigation (managed sidecar = Tauri IPC over Unix sockets; TCP host-side Windows only; loopback fetches dev-gated). Rust-only, +52/−10.Before / After
No visual change.
Test procedure
cargo test --locked(29 incl. both-policy matrix), app tests (9),pnpm verifygreen.Operational notes
Defense-in-depth; next signed release picks it up — fold into the signed-build mic check.
Reviews: security (Sasha — her pre-endorsed finding, verified CLEAR at 9e3f680).
🤖 Generated with Claude Code