Repository navigation
feat(ui): cloud transcription opt-in in Settings → AI (MEET-12) - #378
Merged
Merged
Conversation
eliotlim
enabled auto-merge (squash)
October 6, 2026 14:30
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eliotlim
disabled auto-merge
October 7, 2026 13:37
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cloud transcription ('openai-compat') was API-only; docs pointed at a Settings control that didn't exist, and there was no privacy disclosure at the decision point. Board: MEET-12.
Solution
Transcription provider picker (Default local / Off / Cloud OpenAI-compatible) in the existing AiSettings section: cloud fields (baseUrl/model as placeholders, API key with the chat section's exact write-only semantics + apiKeySet state), privacy note rendered at selection, Whisper status/download gated to local, save/status errors surfaced with last-good restore and guaranteed key scrub on both failure paths, focus-retaining picker with aria-busy, i18n ×4. Bonus: the chat key field now shares the same apply-on-blur path (duplicated scrub logic removed).
Before / After
Small visual addition inside existing settings chrome (text controls; design gate cleared on implementation + fix round).
Test procedure
pnpm --filter @book.dev/ui exec vitest run src/components/__tests__/AiSettings.test.tsx(13 tests);pnpm verifygreen serialized.Operational notes
None. Local remains the blessed default; cloud is deliberate opt-in.
Reviews: design (Devon — BLOCK→CLEAR after error-surfacing fix round), code (Quinn).
🤖 Generated with Claude Code