Repository navigation
fix(sdk,mcp,ui): type meeting transcriptionCompleted keys (MEET-10) - #377
Merged
Merged
Conversation
eliotlim
enabled auto-merge (squash)
October 6, 2026 14:30
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eliotlim
disabled auto-merge
October 7, 2026 13:37
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MEET-5 shipped
transcriptionCompleted: string[]('startedAtMs:assetId') as an untyped passthrough prop — undocumented in the schema, docs, and MCP surface. Board: MEET-10.Solution
Optional, tolerant schema entry (Zod + JSON pattern accepting the full nonneg-finite JS number serialization incl. fractional + e-notation — review caught and fixed a digits-only regex that would have rejected real documents), catalogue hint, docs/meeting-block.md + mcp README rows, negative validation cases, and a recorder-write-vs-schema cross-check with fractional fixtures so this class of drift is caught automatically.
Before / After
No visual change.
Test procedure
pnpm --filter @book.dev/sdk test(blockCatalogue 54+), meeting UI suites, mcp blockTypes/readme/coverage,pnpm verifygreen serialized.Operational notes
None; coverage matrix unchanged (no new block type).
Reviews: code (Quinn — BLOCK→CLEAR after the fractional-key fix, regex executed against JS serialization space).
🤖 Generated with Claude Code