Repository navigation
fix(web): settle sidebar selection color assertions (INF-4) - #375
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
font-weight-layout.spec.tsflaked on CI shard 3 across 4 PRs (#347, #352, #353, #374): sidebar background-color assertions raced a deliberate 180ms hover-wash transition, and the baseline sample depended on pointer position. Board: INF-4 (OB-925).Solution
Deflake without weakening assertions: await fonts ready, require inactive animations and identical consecutive-frame colors before sampling, assert exact resting/hover tokens and restoration of the resting color. Test-only change.
Before / After
No visual change (test-only).
Test procedure
pnpm --filter @book.dev/web exec playwright test font-weight-layout.spec.ts --repeat-each=10Operational notes
None. Board AC tracks 20 consecutive green shard-3 runs post-merge.
Verify: spec 30/30; build/lint/typecheck green. Reviews: none (test-only deflake per gate matrix).
🤖 Generated with Claude Code