Repository navigation
feat(desktop): enable meeting microphone access (MEET-8) - #371
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop app (Tauri/WKWebView) had no microphone entitlement, no usage description, and no documented permission path — meeting recording (MEET-5 / #369) was web-only. Board: MEET-8.
Solution
com.apple.security.device.audio-inputentitlement; newsrc-tauri/Info.plistwith an honestNSMicrophoneUsageDescription(merged via Tauri 2's bare-Info.plist convention — verified against the locked tauri-codegen/bundler source); module docs recording Wry 0.55.1's media-capture delegate behavior (retained, comment-only Rust change); IPC transport test proving two 360 KB chunks (webm+mp4) round-trip byte-for-byte through desktop base64 IPC within the server's exact cap formula. Stacked on #369 — merge after it. No deps, no signing config touched.Key files:
packages/app/src-tauri/{entitlements.plist,Info.plist,src/main.rs},packages/app/src/data/microphoneTransport.test.ts,packages/app/README.md.Before / After
No visual change (native plumbing).
Test procedure
pnpm verifygreen;cargo check --lockedgreen;pnpm --filter @book.dev/app test. Live: README §Manual microphone verification (build, launch, record >45s two chunks, reload persistence, TCC deny/recover).Operational notes
Owner acceptance required on a SIGNED build (signing key unavailable to agents, config untouched): run the README manual steps; step 2's OS prompt implicitly proves the Info.plist merged (hardened runtime hard-crashes without the purpose string — or
plutil -p .../Contents/Info.plist | grep Microphone). Security containment verified in review: nav guard keeps webview first-party; artifact iframes have opaque origins + empty permissions policy. Follow-up filed (MEET-11): gate loopback origins to dev builds — a release-build co-resident-attacker hardening, not a blocker.Verify: green (full suite + both e2e). Reviews cleared: security (Sasha), code (Quinn) — zero fix rounds.
🤖 Generated with Claude Code